From: sashiko-bot@kernel.org
To: "Nora Schiffer" <nora.schiffer@ew.tq-group.com>
Cc: robh@kernel.org, lee@kernel.org, conor+dt@kernel.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 6/7] leds: pca995x: do not use full on LED mode
Date: Wed, 02 Sep 2026 12:39:20 +0000 [thread overview]
Message-ID: <20260902123921.401C41F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <bc5241a0728aa81050d987c26a4c02bdb05d6d20.1788350618.git.nora.schiffer@ew.tq-group.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description is not capitalized, violating subsystem guidelines.
--
commit 01d1bfa03d0ba73721521c5728d8d5c69f3ae3cc
Author: Nora Schiffer <nora.schiffer@ew.tq-group.com>
leds: pca995x: do not use full on LED mode
LEDs in full on mode are unaffected by group dimming. This commit avoids
using full on mode so that group dimming is applied consistently, altering
the brightness at maximum to use a 255/256 duty cycle.
> leds: pca995x: do not use full on LED mode
[Severity: Low]
This isn't a bug, but does this subject line miss the capitalization required
by the LED subsystem guidelines? The convention requires the description after
the subsystem prefix to be capitalized.
--
Sashiko AI review · https://sashiko.dev/#/patchset/6d3600f99c77c31166f0b6a5ccfb7f518b53c4c9.1788350618.git.nora.schiffer@ew.tq-group.com?part=6
next prev parent reply other threads:[~2026-09-02 12:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 12:22 [PATCH 1/7] dt-bindings: leds: pca995x: describe reset-gpios property Nora Schiffer
2026-09-02 12:22 ` [PATCH 2/7] dt-bindings: leds: pca995x: describe output-gain property Nora Schiffer
2026-09-02 12:31 ` sashiko-bot
2026-09-02 13:10 ` Nora Schiffer
2026-09-03 8:34 ` Lee Jones
2026-09-03 13:09 ` Krzysztof Kozlowski
2026-09-02 12:22 ` [PATCH 3/7] leds: pca995x: add support for reset GPIO Nora Schiffer
2026-09-02 12:41 ` sashiko-bot
2026-09-02 12:22 ` [PATCH 4/7] leds: pca995x: make output gain configurable Nora Schiffer
2026-09-02 12:35 ` sashiko-bot
2026-09-02 12:22 ` [PATCH 5/7] leds: pca995x: add sysfs files for error reporting Nora Schiffer
2026-09-02 12:40 ` sashiko-bot
2026-09-02 12:22 ` [PATCH 6/7] leds: pca995x: do not use full on LED mode Nora Schiffer
2026-09-02 12:39 ` sashiko-bot [this message]
2026-09-02 12:22 ` [PATCH 7/7] leds: pca995x: add support for group brightness control Nora Schiffer
2026-09-02 12:43 ` sashiko-bot
2026-09-02 12:37 ` [PATCH 1/7] dt-bindings: leds: pca995x: describe reset-gpios property sashiko-bot
2026-09-02 16:16 ` Lee Jones
2026-09-03 6:42 ` Nora Schiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902123921.401C41F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nora.schiffer@ew.tq-group.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox