From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FA0E3769F5; Wed, 2 Sep 2026 16:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788365361; cv=none; b=Ftr+rrJizXUNxW3WC0OdndsogU0QJNzuj3Nd0/K3O5P5HH3Q1brGGqGlnTJUo4QCzmJcog9aSK8egsl/FndlH5nImOj1H67v+F7nxFBqJmblp6r8QE693cG4EmfEGaKReLXeu2e14hqAdKV6sH0qjez0vpkbkjtYRreh4WfgBIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788365361; c=relaxed/simple; bh=VF9LtaBAM1Mimqpzmnn8bd2gDPV6NtOxfNr/9kgeoyM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lqxStOiWp5tRgvCa+62ZbQZXOtP0qutkjCurzdqa/T+fLYOuhuSIEnDeRAp4lmaFPKNqNebXeeWuW4Okh5bSEPOufDVeLBt3M70AG7joMwD4B3OBDRIC70AunLoNHoqZMGowOK9ZIxIWNtP72HfR11aSm+g6S3sAAzjpgjg6zuU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=adij380J; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="adij380J" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 4D69A40E039E; Wed, 2 Sep 2026 16:09:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EMw9dlDvPqEm; Wed, 2 Sep 2026 16:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1788365343; bh=8EBwRXRgxnDgc1hzoXKaNCqP19NjmMioRMdJEYoHAwY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=adij380JJaT1VPcepZIup1x17uVcz+DEuwbfV4MGy5ccR5YSHhn8LKMEo2oVcw50b K6avUY+ttC70+rhwRgYFOSBiaW0DZhCoQKvHzHp+0zQ87+gzMuXyA71yuDS9XZvswn WjRkl33Q6GS7NG/EOeIGWR/rFL1gcsHoHxNhOkdT8oMLighw9/QIkG8eqKkZTerSVv trSfgLi0cld1yJYAUOCFzmLwboFG2Ktcrbg7W0aTZCtRsHMHbpAwHpYnG6DO2PQKt8 9O1Xc9ZZLUxrGGVOGKR6MbsAhWs4zollXkOFrSOAlqiPrLfqFRo2UqfZtM1AVO067Q 58rObV9SQ1TQ+nQtGP1Otz/m7MJep4FAN30TyIZZ4FdQlOVpc4jCdi7kq8RIOCiV+G FTx1NKT720mBUIDSoEJQvquGLNfNM7skAnJisqS9LD1sUQO09dkml87ZCi+qf3fJGH 2O4n070uB6E4/1Kp2yIeMcU/QMIjh/M3ORK3PQJ8iz/E5CrR8FNq9wkwrfEfQKH3NB gSd2TB63/zLm3HycNcbo+uf2sBPxY/e+hnTMmdRfc1kvPZCR4Qnwu4lLBTRML4KyX/ 155CLDCOAaxzAPIVpiXl3EABqJRUSOTUcrHN7yF/XxDX6nVfdMkUEfiDgThs9z9rd5 a0NoRBfgayOU7NkWATWC595Y= Received: from stx.tnic (unknown [IPv6:2600:1700:38ca:c00::a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4E36C40E024B; Wed, 2 Sep 2026 16:08:47 +0000 (UTC) Date: Wed, 2 Sep 2026 09:08:43 -0700 From: Borislav Petkov To: Ryan Chen Cc: Stefan Schaeckeler , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery , Tony Luck , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Krzysztof Kozlowski , stable@vger.kernel.org Subject: Re: [PATCH v2 0/8] Add Aspeed AST2700 SDRAM EDAC support Message-ID: <20260902160843.GCaphKC-y8HpkiAIWh@fat_crate.local> References: <20260824-edac-v2-0-c8d8bb693586@aspeedtech.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260824-edac-v2-0-c8d8bb693586@aspeedtech.com> On Mon, Aug 24, 2026 at 10:42:27AM +0800, Ryan Chen wrote: > Add ECC error reporting for the Aspeed AST2700 SoC to the existing > aspeed_edac driver. > > The AST2700 memory controller keeps the same overall EDAC programming > model as the earlier Aspeed BMC SoCs, but uses a different register > layout, a split interrupt status/clear/mask scheme and DDR4/DDR5 memory. > Rather than fork the driver, the existing code is first tidied and > generalised, then the AST2700 is added as one more per-SoC variant. > > Patches 2-5 are bug fixes and cleanups to the existing driver. Patches 6 > and 7 rework the implementation to accommodate the AST2700. Patch 8 adds > the AST2700 support itself. Sashiko has comments: https://sashiko.dev/#/patchset/20260824-edac-v2-0-c8d8bb693586%40aspeedtech.com Please address them: if valid, fix them, if not, explain why they don't need to be fixed. Btw, I don't see Stefan reviewing this driver and his last mail on LKML is from 2025 so it looks like we'll orphan this driver too. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette