From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org,
imx@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/1] ARM: dts: imx53: drop fallback compatible "dlg,da9052"
Date: Wed, 02 Sep 2026 19:21:30 +0000 [thread overview]
Message-ID: <20260902192131.07F461F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902191324.2084035-1-Frank.Li@oss.nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] Incomplete fix for DA9052/DA9053 PMIC compatible string fallback mismatch
--
commit 421ff6545162f4ccc6bbeb14037dca411d6337a7
Author: Frank Li <Frank.Li@nxp.com>
ARM: dts: imx53: drop fallback compatible "dlg,da9052"
This commit drops the fallback compatible "dlg,da9052" from the
"dlg,da9053-aa" PMIC nodes in i.MX53 device trees. This prevents incorrect
voltage and current limits from being applied and fixes dtbs_check warnings.
Link: https://lore.kernel.org/imx/20260902-varied-unsent-b99f9f007685@spud/
> diff --git a/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts b/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts
> index 6831836bd726c..e7e15d2b82c44 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx53-qsb.dts
> @@ -13,7 +13,7 @@ / {
>
> &i2c1 {
> pmic: dialog@48 {
> - compatible = "dlg,da9053-aa", "dlg,da9052";
> + compatible = "dlg,da9053-aa";
> reg = <0x48>;
> interrupt-parent = <&gpio7>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>; /* low-level active IRQ at GPIO7_11 */
[Severity: High]
This is a pre-existing issue, but should this patch also update the PMIC
node in arch/arm/boot/dts/nxp/imx/imx53-smd.dts?
Looking at the smd device tree, it has a similar fallback configuration:
arch/arm/boot/dts/nxp/imx/imx53-smd.dts:pmic: dialog@48 {
compatible = "dlg,da9053", "dlg,da9052";
...
}
Because the driver match tables do not contain the generic "dlg,da9053"
string, the core falls back to matching "dlg,da9052". This initializes the
driver with incorrect DA9052 regulator parameters for a DA9053 chip.
Could this expose the smd board to the same hardware risks (incorrect
voltage steps and current limits) described in the commit message? Would it
make sense to remove the fallback here as well to fully resolve the mismatch
across the imx53 boards?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902191324.2084035-1-Frank.Li@oss.nxp.com?part=1
next prev parent reply other threads:[~2026-09-02 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 19:13 [PATCH v2 1/1] ARM: dts: imx53: drop fallback compatible "dlg,da9052" Frank.Li
2026-09-02 19:21 ` sashiko-bot [this message]
2026-09-13 7:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902192131.07F461F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox