From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71DA7382F25 for ; Thu, 3 Sep 2026 20:09:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788466203; cv=none; b=cfc2qu0lOa5N9uBKWrzdUJR07fZrI7A+SuqM0+AlASEz6hxdqZKKCXGcmj9ibbE1qRriQaWWfavXyozbJApGmfQzmkxFjwzFopVrSZNsucP8GYGwNwm7uiL73hXLVFPB3M8VAgrbJ1u5j5y4/6Zt7jvYGc0Ab3jGtKSnoOcPJg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788466203; c=relaxed/simple; bh=yFKfRHQGDijdEKRtQlfMmeXlW6cJECeONVvRTmHPL90=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DC18rcsv2oduhkkS0UAu97s/zpZD8weygZRshGyQIDuHePaiGL0sP8ZiNPT5bkOfSr5qn/bt2x0l/lNVo/S0AfyBeiU0Fajd7LlMYRRhxMEIwxtYmn7cepNHRPySB/+zWOcK0N5+PUBEUi9qwdCsYT9oRj3bJwY0xhHkMqhv8l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ivt2d3kG; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ivt2d3kG" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-4af173320f9so202675b6e.2 for ; Thu, 03 Sep 2026 13:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788466195; x=1789070995; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=85h9R8hU4OlIInyy88aMVvVOyqXeqxmnt2NxcH2V/5I=; b=ivt2d3kGCLlTNvHMDhdQJb7g/K6Xj97Lt+xbu4WjP2EI9iNFXkauKr++NIoAfRiZMP FpwugRePWhUtBCSevqyVfL9GSfdI98RvrsX9wEKcSUs5diLYY9ZlS1kVt9ix41UBtm7e LfPEIQK8mgwU2oMTo9lBxi+xBcaHRhDYkrTBflLxpUuSP1jsHVRzZ+O70QjIxousjl3U h5jKsMtl/T0v/p3J7KC+EQjGFRFMU8pxZlPFaH1bUH8D1rBwfBR/2MtYLAax4PT4KppW hXGG5Q0A452ALZ0IVwE4asOzYWBx/R338aUZs6Ueh4/oEPU/uZBmM+X6PPs8A0tFVo93 KARA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788466195; x=1789070995; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=85h9R8hU4OlIInyy88aMVvVOyqXeqxmnt2NxcH2V/5I=; b=Ccuq6vKfFGgbh0mrIV9SV1iZ11LNQA8oIXOBRzEuGDN0jiBCCa8Tlu8h4iKQY9iUSp ftHUIvZJq/H78SM27ZB2G/nf74B1NR1PYo0HNpAZ0o7jqd9OeMGbvFUh/vhMtpkswJzr uOLIFK4UfCM91pGKIRAbhG3i3ChQDiIUOqILItMVFv1UkCKJVdN8ZvHk+94Mmz1Za+x3 b3oW9M2hTTU2T8OtaqmMc+RLVhhZVMcM0ogPVz9WYkIY8l0jvGYEE0I3ibQafC71iKEs 8UQ1FUnWxRBgyu65uwiFszoXL2dTNDxXhuRI+5rnK2hYgS+Psp3u6YejMy0I2yR0V7S+ 6Pew== X-Forwarded-Encrypted: i=1; AKwUvBxWeEqijNiKTuy6diab4UTyXNheqbmXCMlmpg2Nyugp9thmJ2q5rFLpVlo9y1BhD5ubTFMW0C7F19bn@vger.kernel.org X-Gm-Message-State: AFuF++ka7NREi4ErDJzVp9OEKn+T5DXKdN1sCYp5iEX/t9Rj0YLgpmTz LvQizC8tZyZBNElGZRt+qRnYV2hB/JLpfomfodB5R2JtwvpcqDwR9EnHuLoQWA== X-Gm-Gg: AYBFou2Fnmh/ZaUt56HNGNzE9/yYdYP5SlYCJfIQjRWyknkyx3zDbnjTuRaxKPMKab9 e1Fl2bGZYlobz3PXYSrKUcXmyTw2+MiynoyPM5qiWzv5eaH4NNKFIWGri/a1zRdoUduOH/wPQbl LuPwttqMBjQff6IiMXi5csx/8wRf8h/9GWioa+9j02wSQxHtRg0b7yW7XG/PgO6baMR6gvf2EHC e5BzPddurpme4fjVTYQ7i1PEbL3ckJ07hKzNI7Xfwf7JwPcfra6XDq0/HENqoc2U2KzqWUxogYX cw4PvLDKenKupbVP9aFaE78uWKhfCIDl/xT18PvDER13hnimKF0IlXI8EWE14r+MmfLzDByNZgk 8RbkrrlT+LiGifSc4wUBVZmcyDD78iQJU2OdRXv/nNDXBf0ShGO/5N1YqRgJnsxY1Io9I5DpJMS FEzjfw+XO6jBee530w4KPffAXfdWfP/wmQ929LgITVdrnHmXCxmVd/XZJtpFNvVsVI7K6fDj3z6 5nYOrPljpA+lgxUt0kC+s1rR4x0oeHhzkkoevn29/ZyPooADv9pDE2c/G2l98ymPI9HxULASp4k LWtkYbmqO4pqdKMJ8SAeHWH3lBGucZjRHiaNYF+6CX8uxME/Zz6hWYYeOOocnB/Y2DnBkfFtZWf lO6/p7yo5XphqKuEif0G/wqQR/dcplVs= X-Received: by 2002:a05:6808:30a4:b0:496:892:c58f with SMTP id 5614622812f47-4b960164768mr965196b6e.2.1788466194662; Thu, 03 Sep 2026 13:09:54 -0700 (PDT) Received: from [127.0.1.1] (184-96-151-165.hlrn.qwest.net. [184.96.151.165]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4b971246d9csm252885b6e.7.2026.09.03.13.09.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 13:09:54 -0700 (PDT) From: James Hilliard Date: Thu, 03 Sep 2026 14:09:41 -0600 Subject: [PATCH v9 2/4] mfd: ac200: Add X-Powers AC200 support Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260903-submit-ac200-mfd-v9-2-6b7ed278989c@gmail.com> References: <20260903-submit-ac200-mfd-v9-0-6b7ed278989c@gmail.com> In-Reply-To: <20260903-submit-ac200-mfd-v9-0-6b7ed278989c@gmail.com> To: Lee Jones , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , James Hilliard Cc: Andrew Lunn , "Jagielski, Jedrzej" , Andre Przywara , Chen-Yu Tsai , Jernej Skrabec , linux-sunxi@lists.linux.dev, mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 The X-Powers AC200 is a mixed-signal companion IC with a paged register map accessed over I2C. Enable and rate-lock the shared input clock, wait 40 ms before the first register access, initialize the paged regmap and deassert the common reset. Set only the deassert bit instead of forcing a reset cycle, so state established by firmware or independently powered functions remains intact. Leave the common reset deasserted during driver removal and system shutdown; function drivers own their block resets. The Ethernet PHY is enumerated on its MDIO bus rather than as an MFD child. It follows the x-powers,ac200 phandle and uses this regmap for ancillary package-control access. The audio codec and TV encoder are added as MFD children by subsequent patches. Cache only the common page selector. Individual functions can reset independently and invalidate their other registers, so leave all functional registers volatile. Signed-off-by: James Hilliard --- MAINTAINERS | 1 + drivers/mfd/Kconfig | 12 ++++++ drivers/mfd/Makefile | 1 + drivers/mfd/ac200.c | 113 +++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 127 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 419340093c9b..1d03b0060bda 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -29510,6 +29510,7 @@ M: James Hilliard L: linux-sunxi@lists.linux.dev S: Maintained F: Documentation/devicetree/bindings/mfd/x-powers,ac200.yaml +F: drivers/mfd/ac200.c X-POWERS AXP288 PMIC DRIVERS M: Hans de Goede diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 857ca3bb0d5b..6dea35c8c18e 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -205,6 +205,18 @@ config MFD_AC100 This driver include only the core APIs. You have to select individual components like codecs or RTC under the corresponding menus. +config MFD_AC200 + tristate "X-Powers AC200" + depends on COMMON_CLK + depends on I2C + depends on OF + select REGMAP_I2C + help + Support for the X-Powers AC200 mixed-signal companion IC. The AC200 + contains audio, video, RTC and Fast Ethernet PHY functions and is + co-packaged with some Allwinner H6 and H616 SoCs. This driver provides + the shared register access used by the individual function drivers. + config MFD_AXP20X tristate select MFD_CORE diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 72d3944b0ad8..f8101d2a9ce9 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -150,6 +150,7 @@ obj-$(CONFIG_MFD_DA9052_SPI) += da9052-spi.o obj-$(CONFIG_MFD_DA9052_I2C) += da9052-i2c.o obj-$(CONFIG_MFD_AC100) += ac100.o +obj-$(CONFIG_MFD_AC200) += ac200.o obj-$(CONFIG_MFD_AXP20X) += axp20x.o obj-$(CONFIG_MFD_AXP20X_I2C) += axp20x-i2c.o obj-$(CONFIG_MFD_AXP20X_RSB) += axp20x-rsb.o diff --git a/drivers/mfd/ac200.c b/drivers/mfd/ac200.c new file mode 100644 index 000000000000..94aa13deb0f8 --- /dev/null +++ b/drivers/mfd/ac200.c @@ -0,0 +1,113 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * MFD core driver for the X-Powers AC200 + * + * Copyright (C) 2019 Jernej Skrabec + * Copyright (C) 2026 James Hilliard + */ + +#include +#include +#include +#include +#include + +#define AC200_SYS_CONTROL_REG 0x0002 +#define AC200_SYS_CONTROL_CHIP_RESET_DEASSERT BIT(0) + +/* Interface register accessible from every register page. */ +#define AC200_TWI_REG_ADDR_H 0x00fe +#define AC200_MAX_REG 0xa1f2 + +static const struct regmap_range_cfg ac200_range_cfg[] = { + { + .range_max = AC200_MAX_REG, + .selector_reg = AC200_TWI_REG_ADDR_H, + .selector_mask = 0xff, + .window_len = 256, + }, +}; + +/* + * Each AC200 sub-block can reset independently, invalidating its register + * contents without regmap's knowledge. Cache only the common page selector; + * this avoids a selector read-modify-write for every access on the same page + * without ever returning stale functional-register values. + */ +static bool ac200_volatile_reg(struct device *dev, unsigned int reg) +{ + return reg != AC200_TWI_REG_ADDR_H; +} + +static const struct regmap_config ac200_regmap_config = { + .name = "ac200", + .reg_bits = 8, + .reg_stride = 2, + .val_bits = 16, + .ranges = ac200_range_cfg, + .num_ranges = ARRAY_SIZE(ac200_range_cfg), + .max_register = AC200_MAX_REG, + .volatile_reg = ac200_volatile_reg, + .cache_type = REGCACHE_MAPLE, +}; + +static int ac200_probe(struct i2c_client *client) +{ + struct device *dev = &client->dev; + struct regmap *regmap; + struct clk *clk; + int ret; + + clk = devm_clk_get_enabled(dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to enable input clock\n"); + + ret = devm_clk_rate_exclusive_get(dev, clk); + if (ret) + return dev_err_probe(dev, ret, "failed to lock clock rate\n"); + + regmap = devm_regmap_init_i2c(client, &ac200_regmap_config); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), + "failed to initialize regmap\n"); + + /* + * No minimum delay is documented. Match the vendor driver's 40 ms delay + * before its first AC200 register access after enabling the input clock. + */ + msleep(40); + + ret = regmap_set_bits(regmap, AC200_SYS_CONTROL_REG, + AC200_SYS_CONTROL_CHIP_RESET_DEASSERT); + if (ret) + return ret; + + return 0; +} + +static const struct of_device_id ac200_of_match[] = { + { .compatible = "x-powers,ac200" }, + { } +}; +MODULE_DEVICE_TABLE(of, ac200_of_match); + +static const struct i2c_device_id ac200_i2c_ids[] = { + { .name = "ac200" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, ac200_i2c_ids); + +static struct i2c_driver ac200_driver = { + .driver = { + .name = "ac200", + .of_match_table = ac200_of_match, + }, + .probe = ac200_probe, + .id_table = ac200_i2c_ids, +}; +module_i2c_driver(ac200_driver); + +MODULE_AUTHOR("James Hilliard "); +MODULE_DESCRIPTION("X-Powers AC200 MFD core driver"); +MODULE_LICENSE("GPL"); -- 2.53.0