From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFA18511199 for ; Thu, 3 Sep 2026 20:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788466206; cv=none; b=gF2eeUcPdmoAdfeTWG/m+pXlzDyUuTjuZu5Oh5+5fzThCZUPEEPsKxAS37SmnZl29juxQjovsOOkLHkN7vTEDZMDQ63DY4s6+UD1aXK3uUhaWcDZtblbjiVLSmqRsOBwd21lTZgrGmKoMhnTTG/UcB0twEF/3t5pUNQ75r9YfCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788466206; c=relaxed/simple; bh=EsDOJ0cNSYW7sXQZ77r0mY6GpFlyh6wTRO3okImB9VI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CNotCpPfnw0ZiUJwyQ49TqrlI3n5/iSa7bu1G49QE/8+rgDxCvuhZP22SZFZD2WXT85Qqg9t3q0v9cVY9MviFXdTkTNfQoaFedyx/3LNmMhAbE08jZjQwims8i2t16Uujuxc2aJNPbdm7zFO1B8xt8AdKXvsR05qfIVdnmv4VrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Llg930U2; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Llg930U2" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-4b333de9451so288096b6e.3 for ; Thu, 03 Sep 2026 13:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788466196; x=1789070996; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=amt0kuMl9qCLLKww37f3Z87aRc1WA5oYLF+FoLpW7xg=; b=Llg930U25Fn9PB1pLaypZSguelk3/0Su4V+BnIlJaAoOULGKjn68Hd3SBKUMjGAMKp lix/WXYlkuBkYFIkh7EeEnHK0x9RP6TIPXL4lWUiHLvmdNyYf1804WwlJVrX0Y53sH4e MP3JFFMXEt9sgYnc4xgvX7XcCPaBq0lGf/VIhjUZjlOuirbLtRP7pAVWEnqppCQD/+UC 36KMsPN9WnZ7MkjnJE6pItee37PR3FQLjFugBx04c+c2Fp1zM3zNBkiRUB+IGGgOz71+ dYhSVOgoTJJdWDYM0fC22tu6Qsr4JFzcbl8ssgXBvbwS9/ubAy0ciX25pBV/2RBO4MJ2 tLvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788466196; x=1789070996; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=amt0kuMl9qCLLKww37f3Z87aRc1WA5oYLF+FoLpW7xg=; b=de/XBC1zrT4IeU/xvbK3GhSXMS4IAlt2XC7NpNBvKpupBb3aWf8cAyyzOkdnW5qyPk rSqUViZtj6OSrZBSnpMoj43Taanmxt351LYg5uU555T76Pk3dPZD+Mocex3KG8v7Ie9e fiCMZUA7fB5bvR1uvbkUgNEmNA/vwuijkoKht7mcx2bsyaR4jrqUJAndSj/T9LAArynf plljyR0jZDoi2bb7dKIzXOMCzqSoT6cSo3qlyuuORmmc7DPa9W65w/jm69WxK8BH286k BSYV27BGANXWVkHlzQbwlbyYcKKUX+lJ2m90IljA/uBjmSJ5RuvdQEh8UkuqSE3quDSy vlUA== X-Forwarded-Encrypted: i=1; AKwUvBxQNPu9/+2sHVNtTYeJICT1pt0O4le2bAlgkUTaX3I2GbCAJpxkwUlQYssaF4TRr7yDi/RJ2D3drqss@vger.kernel.org X-Gm-Message-State: AFuF++lSPG0elotAOq1M79hPaHjQwyqOpCM1Ze2Pz1Ba/C9oTGSEa9ea e8Rd6vtYZqoz0VCgTlUKLM/U4p4bQ7gpkuh3DFBTVq5cJY/HpVhGFxm/ X-Gm-Gg: AYBFou2VGrx/iuggyG0OR0D/804IBrOZ1gnj6QckwozhSBiZbofAnBB8sjjF3n/4nRX PBZuDjg7KRGveStye4MQc6HX/qhAU/O+m47Koz9C10nOGBRQ3l2CYegEBz7ynR7Cvsusl6GCTBB 4KF6PMEQJPvtYpcvvsSMb/2vAIx9zfP6bZE8HT83Z2CKiu6K8JgKVlc67OOvVt1aDecTy7lssVV cR7valgSKcedQaThoDeV8ZxGzbKbZdP1E23SHKpB3ZjO1F4jKRhhZ6212ER9xNwoyDuauC2wHjz s81IVTIZ3oWOsK++jC90UWQGfbozQg6DMYxVWiH3BWEWkSynmzu8FI6PTkJ8t1Bj0GUjnBQPaA0 KSs0C0JcxpjaKN7+7zEBUgJfbmmx5Q1X6XQv87ifHAedqizgRU2IVOhTKZqVLC+Tf0SGIqj6zGY +yP0u6IHj/tdyYPo2/BzsOwFQMoVMlyhB/I/2AAIhKvtkPt8kW94YuJlsUlcO92vAR+fOqMctFj zStx94RQxBiU/McMlEytfvXJR5QMrXBODkWkJBZ/99yBptNXzQBIzIzjfuauFtEyEd5IgmtzuQZ WqhTso73vYHlRt61OPbt1ZdaXGOW+pBEdRYRMlQIMjZ0q+mlYhWEfbT5PmIvjsIF7hH6rHUBtXM WxWrrFtPS5E6MHR/IQPOiXG4O1+aqEA== X-Received: by 2002:a05:6808:1445:b0:4b3:880a:f07f with SMTP id 5614622812f47-4b95fb4ebcamr1040808b6e.1.1788466196555; Thu, 03 Sep 2026 13:09:56 -0700 (PDT) Received: from [127.0.1.1] (184-96-151-165.hlrn.qwest.net. [184.96.151.165]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4b971246d9csm252885b6e.7.2026.09.03.13.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 13:09:56 -0700 (PDT) From: James Hilliard Date: Thu, 03 Sep 2026 14:09:43 -0600 Subject: [PATCH v9 4/4] mfd: ac200: Add codec and TV encoder cells Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260903-submit-ac200-mfd-v9-4-6b7ed278989c@gmail.com> References: <20260903-submit-ac200-mfd-v9-0-6b7ed278989c@gmail.com> In-Reply-To: <20260903-submit-ac200-mfd-v9-0-6b7ed278989c@gmail.com> To: Lee Jones , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , James Hilliard Cc: Andrew Lunn , "Jagielski, Jedrzej" , Andre Przywara , Chen-Yu Tsai , Jernej Skrabec , linux-sunxi@lists.linux.dev, mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 From: Jernej Skrabec Register the AC200 audio codec and TV encoder as MFD cells when their enabled child nodes are present. Filtering the cell list avoids creating unused platform devices, or warnings about missing firmware nodes, on boards which use only the separately enumerated MDIO PHY. Add a regmap IRQ controller for the shared level-triggered INTB output so the TV encoder can consume its cable-detection interrupt. The source function remains responsible for clearing its interrupt condition. Signed-off-by: Jernej Skrabec Signed-off-by: Andre Przywara Signed-off-by: James Hilliard --- drivers/mfd/Kconfig | 5 ++- drivers/mfd/ac200.c | 119 +++++++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 122 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 6dea35c8c18e..5193c6f71bd8 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -210,12 +210,15 @@ config MFD_AC200 depends on COMMON_CLK depends on I2C depends on OF + select MFD_CORE select REGMAP_I2C + select REGMAP_IRQ help Support for the X-Powers AC200 mixed-signal companion IC. The AC200 contains audio, video, RTC and Fast Ethernet PHY functions and is co-packaged with some Allwinner H6 and H616 SoCs. This driver provides - the shared register access used by the individual function drivers. + the shared register access and instantiates the individual function + devices. config MFD_AXP20X tristate diff --git a/drivers/mfd/ac200.c b/drivers/mfd/ac200.c index 94aa13deb0f8..f7d818141d9c 100644 --- a/drivers/mfd/ac200.c +++ b/drivers/mfd/ac200.c @@ -9,11 +9,24 @@ #include #include #include +#include +#include +#include #include +#include #include +#include + #define AC200_SYS_CONTROL_REG 0x0002 #define AC200_SYS_CONTROL_CHIP_RESET_DEASSERT BIT(0) +#define AC200_SYS_IRQ_ENABLE_REG 0x0004 +#define AC200_SYS_IRQ_INTB_ENABLE BIT(15) +#define AC200_SYS_IRQ_INTB_ACTIVE_HIGH BIT(14) +#define AC200_SYS_IRQ_RTC BIT(12) +#define AC200_SYS_IRQ_EPHY BIT(8) +#define AC200_SYS_IRQ_TVE BIT(4) +#define AC200_SYS_IRQ_STATUS_REG 0x0006 /* Interface register accessible from every register page. */ #define AC200_TWI_REG_ADDR_H 0x00fe @@ -51,6 +64,103 @@ static const struct regmap_config ac200_regmap_config = { .cache_type = REGCACHE_MAPLE, }; +static const struct regmap_irq ac200_irqs[] = { + REGMAP_IRQ_REG(AC200_IRQ_TVE, 0, AC200_SYS_IRQ_TVE), + REGMAP_IRQ_REG(AC200_IRQ_EPHY, 0, AC200_SYS_IRQ_EPHY), + REGMAP_IRQ_REG(AC200_IRQ_RTC, 0, AC200_SYS_IRQ_RTC), +}; + +/* + * SYS_IRQ_ENABLE is an enable register rather than a mask register, hence + * unmask_base. SYS_IRQ_STATUS reflects the source levels, so the function + * which raised an interrupt is responsible for clearing it. + */ +static const struct regmap_irq_chip ac200_irq_chip = { + .name = "ac200", + .status_base = AC200_SYS_IRQ_STATUS_REG, + .unmask_base = AC200_SYS_IRQ_ENABLE_REG, + .num_regs = 1, + .irqs = ac200_irqs, + .num_irqs = ARRAY_SIZE(ac200_irqs), +}; + +static const struct mfd_cell ac200_cells[] = { + { + .name = "ac200-codec", + .of_compatible = "x-powers,ac200-codec", + }, { + .name = "ac200-tve", + .of_compatible = "x-powers,ac200-tve", + }, +}; + +static int ac200_init_irq(struct device *dev, struct regmap *regmap, int irq) +{ + struct regmap_irq_chip_data *irq_data; + unsigned int trigger; + u16 value = AC200_SYS_IRQ_INTB_ENABLE; + int ret; + + trigger = irq_get_trigger_type(irq); + switch (trigger) { + case IRQ_TYPE_LEVEL_HIGH: + value |= AC200_SYS_IRQ_INTB_ACTIVE_HIGH; + break; + case IRQ_TYPE_NONE: + case IRQ_TYPE_LEVEL_LOW: + break; + default: + return dev_err_probe(dev, -EINVAL, + "INTB is level triggered, not type %u\n", + trigger); + } + + ret = regmap_update_bits(regmap, AC200_SYS_IRQ_ENABLE_REG, + AC200_SYS_IRQ_INTB_ENABLE | + AC200_SYS_IRQ_INTB_ACTIVE_HIGH, value); + if (ret) + return ret; + + ret = devm_regmap_add_irq_chip(dev, regmap, irq, IRQF_ONESHOT, 0, + &ac200_irq_chip, &irq_data); + if (ret) + return dev_err_probe(dev, ret, "failed to add IRQ chip\n"); + + return 0; +} + +static int ac200_add_devices(struct device *dev) +{ + struct mfd_cell cells[ARRAY_SIZE(ac200_cells)]; + unsigned int num_cells = 0; + unsigned int i; + int ret; + + for (i = 0; i < ARRAY_SIZE(ac200_cells); i++) { + const struct mfd_cell *cell = &ac200_cells[i]; + struct device_node *child; + + child = of_get_compatible_child(dev->of_node, + cell->of_compatible); + if (!child) + continue; + if (of_device_is_available(child)) + cells[num_cells++] = *cell; + of_node_put(child); + } + + if (!num_cells) + return 0; + + ret = devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE, cells, num_cells, + NULL, 0, NULL); + if (ret) + return dev_err_probe(dev, ret, + "failed to add function devices\n"); + + return 0; +} + static int ac200_probe(struct i2c_client *client) { struct device *dev = &client->dev; @@ -83,7 +193,13 @@ static int ac200_probe(struct i2c_client *client) if (ret) return ret; - return 0; + if (client->irq > 0) { + ret = ac200_init_irq(dev, regmap, client->irq); + if (ret) + return ret; + } + + return ac200_add_devices(dev); } static const struct of_device_id ac200_of_match[] = { @@ -108,6 +224,7 @@ static struct i2c_driver ac200_driver = { }; module_i2c_driver(ac200_driver); +MODULE_AUTHOR("Jernej Skrabec "); MODULE_AUTHOR("James Hilliard "); MODULE_DESCRIPTION("X-Powers AC200 MFD core driver"); MODULE_LICENSE("GPL"); -- 2.53.0