From: Hongliang Yang <hongliang.yang@cixtech.com>
To: krzk@kernel.org
Cc: cix-kernel-upstream@cixtech.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, fugang.duan@cixtech.com,
gregkh@linuxfoundation.org, hongliang.yang@cixtech.com,
krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-usb@vger.kernel.org, neil.armstrong@linaro.org,
p.zabel@pengutronix.de, pawell@cadence.com,
peter.chen@kernel.org, robh@kernel.org, rogerq@kernel.org,
vkoul@kernel.org
Subject: [PATCH v3 0/5] Add CIX Sky1 USB3/USBSSP support
Date: Thu, 3 Sep 2026 10:35:16 +0800 [thread overview]
Message-ID: <20260903023521.2064986-1-hongliang.yang@cixtech.com> (raw)
In-Reply-To: <503e87d9-3311-413a-98c0-e02a02c4a354@kernel.org>
Add USB3 PHY binding and driver, Cadence USBSSP glue binding and
driver, and USB4/USB5 device tree nodes for the CIX Sky1 SoC.
This series adds support for the USB4 and USB5 controllers (based on
Cadence USBSSP DRD) found on the CIX Sky1 SoC, along with their
associated multi-port USB3 PHY.
The two wrapper nodes each carry two 4-byte register windows: these
are per-controller RCSU control/status registers (AXI cache attribute
and clock-status) that live inside the shared RCSU aperture, so they
cannot be expressed as a syscon; the OTG mode straps live in the S5
system control block and are referenced through the cix,usb-syscon
phandle. This was discussed during review of v1 [1].
Changes in v3:
Device tree:
- Fix the interrupt specifiers of the usb4/usb5 child nodes: the Sky1
GICv3 interrupt controller uses 4 cells, so add the missing fourth
(empty) cell to every entry. Without it the controller IRQs cannot
be resolved (platform_get_irq_byname() returns -ENXIO).
USB3 PHY driver:
- Assert the hardware resets before registering the PHY provider, so a
consumer cannot race with the probe-time assertion.
- Disable the clocks in LIFO order (ref before apb) in phy_exit().
- Reorder the error unroll path of phy_init() to assert the resets
before disabling the clocks, matching the teardown sequence, and fix
the goto targets so clocks that were never enabled are not disabled.
- Check fwnode_get_name() for NULL and only match "usb-port@" child
nodes exactly, instead of any name with a "usb-port" or "USB" prefix.
USBSSP glue driver:
- Add error cleanup to the probe paths: unmap the xhci/dev registers,
assert the resets and disable the clocks.
- Replace the static of_dev_auxdata array with a probe-local one and
allocate the platform data with devm_kzalloc(), so repeated probes
cannot corrupt shared state or leak the allocation.
- Quiesce the hardware on remove: assert (not deassert) the resets
before disabling the clocks, and balance the runtime PM usage count
with pm_runtime_disable()/pm_runtime_set_suspended()/
pm_runtime_put_noidle().
- Check cdns->host_dev for NULL before dereferencing it in the
platform suspend callback.
- Drop the reference of the OF node returned by of_get_next_child().
- Stop clearing the clock pointers in the enable error paths, which
left NULL pointers in the driver state on later resume attempts.
- Take device references in the shutdown child-iteration callbacks and
drop them after use to avoid a use-after-free.
- Use BIT(31) instead of a signed 1 << 31 shift.
- Assign the system sleep callbacks with SYSTEM_SLEEP_PM_OPS() and
pm_sleep_ptr() instead of a plain dev_pm_ops behind #ifdef.
[1] https://lore.kernel.org/linux-phy/20260902032306.1182941-1-hongliang.yang@cixtech.com/
Hongliang Yang (5):
dt-bindings: phy: Add CIX Sky1 USB3 PHY
dt-bindings: usb: Add CIX Sky1 USBSSP controller
phy: cix: Add CIX Sky1 USB3 PHY driver
usb: cdns3: Add CIX Sky1 glue driver
arm64: dts: cix: Add USB4/USB5 nodes for Sky1
.../bindings/phy/cix,sky1-usb3-phy.yaml | 107 +++
.../bindings/usb/cix,sky1-usbssp.yaml | 137 ++++
MAINTAINERS | 3 +
arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 54 ++
arch/arm64/boot/dts/cix/sky1.dtsi | 118 +++
drivers/phy/Kconfig | 1 +
drivers/phy/Makefile | 1 +
drivers/phy/cix/Kconfig | 20 +
drivers/phy/cix/Makefile | 6 +
drivers/phy/cix/phy-cix-usb3.c | 410 +++++++++++
drivers/phy/cix/phy-cix-usbdp.h | 310 ++++++++
drivers/usb/cdns3/Kconfig | 13 +
drivers/usb/cdns3/Makefile | 1 +
drivers/usb/cdns3/cdnsp-sky1.c | 696 ++++++++++++++++++
drivers/usb/cdns3/cdnsp-sky1.h | 127 ++++
15 files changed, 2004 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/cix,sky1-usb3-phy.yaml
create mode 100644 Documentation/devicetree/bindings/usb/cix,sky1-usbssp.yaml
create mode 100644 drivers/phy/cix/Kconfig
create mode 100644 drivers/phy/cix/Makefile
create mode 100644 drivers/phy/cix/phy-cix-usb3.c
create mode 100644 drivers/phy/cix/phy-cix-usbdp.h
create mode 100644 drivers/usb/cdns3/cdnsp-sky1.c
create mode 100644 drivers/usb/cdns3/cdnsp-sky1.h
--
2.54.0
next prev parent reply other threads:[~2026-09-03 2:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 8:23 [PATCH v1 0/4] Add CIX Sky1 USB3/USBSSP support Hongliang Yang
2026-08-31 8:23 ` [PATCH v1 1/4] dt-bindings: Add CIX Sky1 USB bindings Hongliang Yang
2026-08-31 8:32 ` sashiko-bot
2026-08-31 16:07 ` Conor Dooley
2026-09-01 5:47 ` Krzysztof Kozlowski
2026-09-02 3:23 ` Hongliang Yang
2026-09-03 6:28 ` Krzysztof Kozlowski
2026-09-03 2:35 ` Hongliang Yang [this message]
2026-09-03 2:35 ` [PATCH v3 1/5] dt-bindings: phy: Add CIX Sky1 USB3 PHY Hongliang Yang
2026-09-03 2:35 ` [PATCH v3 2/5] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang
2026-09-03 6:30 ` Krzysztof Kozlowski
2026-09-03 2:35 ` [PATCH v3 3/5] phy: cix: Add CIX Sky1 USB3 PHY driver Hongliang Yang
2026-09-03 2:48 ` sashiko-bot
2026-09-03 2:35 ` [PATCH v3 4/5] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang
2026-09-03 2:45 ` sashiko-bot
2026-09-03 2:35 ` [PATCH v3 5/5] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang
2026-09-03 6:29 ` [PATCH v3 0/5] Add CIX Sky1 USB3/USBSSP support Krzysztof Kozlowski
2026-08-31 8:23 ` [PATCH v1 2/4] phy: cix: Add CIX Sky1 USB3 PHY driver Hongliang Yang
2026-08-31 8:33 ` sashiko-bot
2026-08-31 8:23 ` [PATCH v1 3/4] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang
2026-08-31 8:41 ` sashiko-bot
2026-08-31 8:57 ` Philipp Zabel
2026-08-31 8:23 ` [PATCH v1 4/4] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang
2026-08-31 8:33 ` sashiko-bot
2026-09-02 3:21 ` [PATCH v2 0/5] Add CIX Sky1 USB3/USBSSP support Hongliang Yang
2026-09-02 3:21 ` [PATCH v2 1/5] dt-bindings: phy: Add CIX Sky1 USB3 PHY Hongliang Yang
2026-09-02 3:21 ` [PATCH v2 2/5] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang
2026-09-02 3:21 ` [PATCH v2 3/5] phy: cix: Add CIX Sky1 USB3 PHY driver Hongliang Yang
2026-09-02 3:32 ` sashiko-bot
2026-09-02 3:21 ` [PATCH v2 4/5] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang
2026-09-02 3:32 ` sashiko-bot
2026-09-02 3:21 ` [PATCH v2 5/5] arm64: dts: cix: Add USB4/USB5 nodes for Sky1 Hongliang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903023521.2064986-1-hongliang.yang@cixtech.com \
--to=hongliang.yang@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox