From: sashiko-bot@kernel.org
To: "Wayne Chang" <waynec@nvidia.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH V3 3/3] usb: host: xhci-tegra: Add Tegra264 XHCI support
Date: Thu, 03 Sep 2026 08:05:19 +0000 [thread overview]
Message-ID: <20260903080519.892D71F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260903074539.613220-4-waynec@nvidia.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Undocumented behavioral change: `.enable_firmware_messages` is disabled for Tegra264, contradicting the commit message.
--
commit 9801b6744662599081fdad0fae6db596ecae9f70
Author: Wayne Chang <waynec@nvidia.com>
usb: host: xhci-tegra: Add Tegra264 XHCI support
This commit adds Tegra264 XUSB host mode controller support. The new host
controller is described as being identical to the existing Tegra234 XHCI
with the exception of the max_num_wakes value.
> diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
> index a16c4a8233472..a973cfa4b13b0 100644
> --- a/drivers/usb/host/xhci-tegra.c
> +++ b/drivers/usb/host/xhci-tegra.c
[ ... ]
> @@ -2753,12 +2753,40 @@ static const struct tegra_xusb_soc tegra234_soc = {
> .enable_firmware_messages = true,
> };
>
> +static const struct tegra_xusb_soc tegra264_soc = {
[ ... ]
> + .lpm_support = true,
> + .has_bar2 = true,
> + .enable_firmware_messages = false,
[Severity: Medium]
The commit message states that the Tegra264 host controller is very similar
to the existing Tegra234 XHCI, except for the number of max_num_wakes. However,
this structure explicitly disables firmware messages for tegra264_soc, whereas
it is enabled for tegra234_soc.
Is this undocumented change intentional? If so, could the commit message be
updated to reflect that firmware messages are also disabled for Tegra264?
> +};
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260903074539.613220-1-waynec@nvidia.com?part=3
prev parent reply other threads:[~2026-09-03 8:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 7:45 [PATCH V3 0/3] usb: host: xhci-tegra: Add Tegra264 XHCI support Wayne Chang
2026-09-03 7:45 ` [PATCH V3 1/3] dt-bindings: usb: Add Tegra264 XUSB host support Wayne Chang
2026-09-03 17:33 ` Conor Dooley
2026-09-03 7:45 ` [PATCH V3 2/3] usb: host: xhci-tegra: Skip MBOX MSG_ENABLED on Tegra264 Wayne Chang
2026-09-03 7:45 ` [PATCH V3 3/3] usb: host: xhci-tegra: Add Tegra264 XHCI support Wayne Chang
2026-09-03 8:05 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903080519.892D71F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=waynec@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox