From: sashiko-bot@kernel.org
To: "Janne Grunau" <j@jannau.net>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/3] arm64: dts: apple: Fix style issues for t602x multi die .dtsi
Date: Thu, 03 Sep 2026 14:13:30 +0000 [thread overview]
Message-ID: <20260903141330.AC03A1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260903-apple-soc-multi-die-style-v1-2-eeb05ea0c187@jannau.net>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `#undef SOC_NODE` in `t6021.dtsi` pollutes the preprocessor namespace for any files that include it.
--
commit 15841a7911d15e65ab6085742e273164257c003e
Author: Janne Grunau <j@jannau.net>
arm64: dts: apple: Fix style issues for t602x multi die .dtsi
The M2 Pro/Max/Ultra .dtsi files containing most MMIO nodes are a
collection of nodes without parent. The proper embedding inside a
"simple-bus" parent only happens in t6021.dtsi and t6022.dtsi.
Fix these dt style issue by using a define for their parent soc node and
bracket those MMIO nodes inside it.
Link: https://lore.kernel.org/asahi/e2365307-32d6-4ef9-9919-55ba69786741@kernel.org/
> diff --git a/arch/arm64/boot/dts/apple/t6021.dtsi b/arch/arm64/boot/dts/apple/t6021.dtsi
> index 5175797baf621..3cddc1697e147 100644
> --- a/arch/arm64/boot/dts/apple/t6021.dtsi
> +++ b/arch/arm64/boot/dts/apple/t6021.dtsi
> @@ -35,13 +35,11 @@ soc {
>
> #define DIE
> #define DIE_NO 0
> +#define SOC_NODE {/soc}
>
> -&{/soc} {
> - #include "t602x-die0.dtsi"
> - #include "t602x-dieX.dtsi"
> - #include "t602x-nvme.dtsi"
> -};
> -
> +#include "t602x-die0.dtsi"
> +#include "t602x-dieX.dtsi"
> +#include "t602x-nvme.dtsi"
> #include "t602x-gpio-pins.dtsi"
> #include "t602x-pmgr.dtsi"
[Severity: Low]
Does this leave the SOC_NODE macro defined for any file including t6021.dtsi?
There are existing macro cleanups right after this block in the file:
#undef DIE
#undef DIE_NO
&aic {
Is an #undef SOC_NODE missing here? Leaving it defined pollutes the
preprocessor namespace and deviates from the cleanup pattern used in sibling
files like t6022.dtsi.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260903-apple-soc-multi-die-style-v1-0-eeb05ea0c187@jannau.net?part=2
next prev parent reply other threads:[~2026-09-03 14:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 13:59 [PATCH 0/3] Fix dt-style-check issues in Apple silicon multi die .dtsi Janne Grunau
2026-09-03 13:59 ` [PATCH 1/3] arm64: dts: apple: Fix style issues for t600x " Janne Grunau
2026-09-04 6:22 ` Krzysztof Kozlowski
2026-09-03 13:59 ` [PATCH 2/3] arm64: dts: apple: Fix style issues for t602x " Janne Grunau
2026-09-03 14:13 ` sashiko-bot [this message]
2026-09-04 6:22 ` Krzysztof Kozlowski
2026-09-03 13:59 ` [PATCH 3/3] arm64: dts: apple: Fix style issues for t6031 " Janne Grunau
2026-09-04 6:23 ` Krzysztof Kozlowski
2026-09-04 15:08 ` [PATCH 0/3] Fix dt-style-check issues in Apple silicon " Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903141330.AC03A1F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox