Re: [PATCH v9 2/4] mfd: ac200: Add X-Powers AC200 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Regmap exposed to userspace and consumers before hardware initialization delay completes.
--

commit 35526ae046a1822af569d5228aa956640657303c
Author: James Hilliard <james.hilliard1@gmail.com>

mfd: ac200: Add X-Powers AC200 support

This commit adds MFD core driver support for the X-Powers AC200 mixed-signal
companion IC. It configures the shared regmap over I2C, handles clock
enabling, and manages the common reset state for the device.

> diff --git a/drivers/mfd/ac200.c b/drivers/mfd/ac200.c
> new file mode 100644
> index 0000000000000..94aa13deb0f8c
> --- /dev/null
> +++ b/drivers/mfd/ac200.c

[ ... ]

> +static int ac200_probe(struct i2c_client *client)
> +{
> +	struct device *dev = &client->dev;
> +	struct regmap *regmap;
> +	struct clk *clk;
> +	int ret;
> +
> +	clk = devm_clk_get_enabled(dev, NULL);
> +	if (IS_ERR(clk))
> +		return dev_err_probe(dev, PTR_ERR(clk),
> +				     "failed to enable input clock\n");
> +
> +	ret = devm_clk_rate_exclusive_get(dev, clk);
> +	if (ret)
> +		return dev_err_probe(dev, ret, "failed to lock clock rate\n");
> +
> +	regmap = devm_regmap_init_i2c(client, &ac200_regmap_config);
> +	if (IS_ERR(regmap))
> +		return dev_err_probe(dev, PTR_ERR(regmap),
> +				     "failed to initialize regmap\n");
> +
> +	/*
> +	 * No minimum delay is documented. Match the vendor driver's 40 ms delay
> +	 * before its first AC200 register access after enabling the input clock.
> +	 */
> +	msleep(40);

[Severity: Medium]
Could exposing the regmap before the 40 ms initialization delay completes lead
to I2C bus lockups or device malfunctions?

The devm_regmap_init_i2c() call exposes the regmap to userspace via debugfs
and to other consumers, such as an asynchronously probing Ethernet PHY. During
this 40 ms window, these concurrent access paths might attempt to access the
hardware before the stabilization delay is met.

Would it be safer to move the msleep(40) above the regmap initialization to
prevent this race condition?

> +
> +	ret = regmap_set_bits(regmap, AC200_SYS_CONTROL_REG,
> +			      AC200_SYS_CONTROL_CHIP_RESET_DEASSERT);
> +	if (ret)
> +		return ret;
> +
> +	return 0;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903-submit-ac200-mfd-v9-0-6b7ed278989c@gmail.com?part=2