Re: [PATCH 2/2] ASoC: codecs: nau8360: Add default PEQ band number for DSP init

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing bit shift for NAU8360_PEQ_BAND_8 causes the PEQ band field to be incorrectly cleared to 0 instead of being set to 8.
--

commit dcc017a933844c3bdb0f174e1e0108fe17fff20e
Author: Neo Chang <YLCHANG2@nuvoton.com>

ASoC: codecs: nau8360: Add default PEQ band number for DSP init

This commit sets a default PEQ band number during DSP initialization in the
nau8360 codec. The goal is to prevent invalid states or uninitialized
parameters before user configuration is applied.

> diff --git a/sound/soc/codecs/nau8360.c b/sound/soc/codecs/nau8360.c
> index b3cf207eea86d..5a94e9a3072a5 100644
> --- a/sound/soc/codecs/nau8360.c
> +++ b/sound/soc/codecs/nau8360.c
> @@ -1602,6 +1602,8 @@ static void nau8360_coeff_set_def(struct nau8360 *nau8360)
>  			i * NAU8360_TOT_BAND_COE_RANGE, 0x20);
>  	}
>  	nau8360_peq_mem_enable(regmap, false);
> +	regmap_update_bits(regmap, NAU8360_R9D_PEQ_CTL, NAU8360_PEQ_BAND_MASK,
> +		NAU8360_PEQ_BAND_8);

[Severity: High]
Does this code clear the band field to 0 instead of setting it to 8?

In sound/soc/codecs/nau8360.h, NAU8360_PEQ_BAND_MASK is shifted:

#define NAU8360_PEQ_BAND_MASK (0xf << NAU8360_PEQ_BAND_SFT)

But NAU8360_PEQ_BAND_8 evaluates to 8 unshifted. Because it is passed
without the shift here, the value applied against the shifted mask becomes
zero.

Other uses of this field in the driver explicitly shift the value,
such as:

regmap_update_bits(regmap, NAU8360_R9D_PEQ_CTL, NAU8360_PEQ_BAND_MASK,
	value << NAU8360_PEQ_BAND_SFT);

Could this regression in the bit shift cause incorrect DSP initialization?

>  	mutex_unlock(&nau8360->lock);
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904024456.193528-1-YLCHANG2@nuvoton.com?part=2