From: sashiko-bot@kernel.org
To: "Long Zhao" <longzhao@ambarella.com>
Cc: linux-serial@vger.kernel.org, linux-clk@vger.kernel.org,
robh@kernel.org, devicetree@vger.kernel.org, mfd@lists.linux.dev,
lee@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v6 02/13] dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad
Date: Fri, 04 Sep 2026 06:45:42 +0000 [thread overview]
Message-ID: <20260904064542.7D31B1F00A3F@smtp.kernel.org> (raw)
In-Reply-To: <20260904-cv75-v5-v6-2-e918514cb3b1@ambarella.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The newly added compatible string 'ambarella,cv75-sec-scratchpad' is omitted from the schema's `select` block.
- [Low] The commit message description is not capitalized, violating MFD subsystem guidelines.
--
commit 76aff96b4864d15974efdf2aaee9ee5e0a165b88
Author: Long Zhao <longzhao@ambarella.com>
dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad
Allow ambarella,cv75-sec-scratchpad as a syscon for the shared secure
scratchpad registers on CV75.
> dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad
[Severity: Low]
This isn't a bug, but should the commit message description be capitalized
("Add Ambarella CV75...") to adhere to MFD subsystem guidelines?
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index e228670880631..05c7f59aba5de 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -148,6 +148,7 @@ properties:
> - allwinner,sun50i-a64-system-controller
> - altr,l3regs
> - altr,sdr-ctl
> + - ambarella,cv75-sec-scratchpad
[Severity: Low]
Does this compatible string also need to be added to the select block at the
beginning of the file?
Documentation/devicetree/bindings/mfd/syscon.yaml:select:properties:compatible:contains:enum
- altr,l3regs
- altr,sdr-ctl
- ambarella,cv75-sec-scratchpad
- amd,pensando-elba-syscon
Without this addition, older versions of dtschema (<2024.02) will silently skip
schema validation for nodes using this compatible string.
> - amd,pensando-elba-syscon
> - amlogic,meson-mx-assist
> - amlogic,meson-mx-bootrom
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-cv75-v5-v6-0-e918514cb3b1@ambarella.com?part=2
next prev parent reply other threads:[~2026-09-04 6:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 6:38 [PATCH v6 00/13] Ambarella CV75 SoC minimal bring-up Long Zhao via B4 Relay
2026-09-04 6:38 ` [PATCH v6 01/13] dt-bindings: arm: add Ambarella CV75 platforms Long Zhao via B4 Relay
2026-09-04 6:42 ` sashiko-bot
2026-09-04 22:39 ` Linus Walleij
2026-09-04 6:38 ` [PATCH v6 02/13] dt-bindings: mfd: syscon: add Ambarella CV75 secure scratchpad Long Zhao via B4 Relay
2026-09-04 6:45 ` sashiko-bot [this message]
2026-09-04 6:38 ` [PATCH v6 03/13] dt-bindings: clock: add Ambarella CV75 RCT Long Zhao via B4 Relay
2026-09-04 6:45 ` sashiko-bot
2026-09-04 6:38 ` [PATCH v6 04/13] dt-bindings: pinctrl: add Ambarella CV75 pinctrl Long Zhao via B4 Relay
2026-09-04 6:45 ` sashiko-bot
2026-09-04 22:40 ` Linus Walleij
2026-09-04 6:38 ` [PATCH v6 05/13] dt-bindings: gpio: pl061: add Ambarella CV75 variant Long Zhao via B4 Relay
2026-09-04 6:47 ` sashiko-bot
2026-09-04 14:45 ` Rob Herring
2026-09-04 6:38 ` [PATCH v6 06/13] dt-bindings: serial: snps-dw-apb-uart: add ambarella,cv75-uart Long Zhao via B4 Relay
2026-09-04 6:42 ` sashiko-bot
2026-09-04 22:41 ` Linus Walleij
2026-09-04 6:38 ` [PATCH v6 07/13] clk: ambarella: add CV75 CCU driver Long Zhao via B4 Relay
2026-09-04 6:53 ` sashiko-bot
2026-09-04 7:44 ` Jerome Brunet
2026-09-04 9:21 ` zl020895
2026-09-04 6:38 ` [PATCH v6 08/13] gpio: regmap: support write_data_after_dir and girq Long Zhao via B4 Relay
2026-09-04 6:54 ` sashiko-bot
2026-09-04 11:55 ` Andy Shevchenko
2026-09-04 6:38 ` [PATCH v6 09/13] gpio: pl061: use gpio-regmap and add Ambarella layout Long Zhao via B4 Relay
2026-09-04 6:49 ` sashiko-bot
2026-09-04 13:14 ` Andy Shevchenko
2026-09-04 6:38 ` [PATCH v6 10/13] pinctrl: ambarella: add CV75 pin controller Long Zhao via B4 Relay
2026-09-04 6:50 ` sashiko-bot
2026-09-04 13:29 ` Andy Shevchenko
2026-09-04 6:38 ` [PATCH v6 11/13] serial: 8250_dw: add Ambarella CV75 quirks Long Zhao via B4 Relay
2026-09-04 6:51 ` sashiko-bot
2026-09-04 22:45 ` Linus Walleij
2026-09-04 22:43 ` Linus Walleij
2026-09-04 6:38 ` [PATCH v6 12/13] arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT Long Zhao via B4 Relay
2026-09-04 6:48 ` sashiko-bot
2026-09-04 22:45 ` Linus Walleij
2026-09-04 6:38 ` [PATCH v6 13/13] MAINTAINERS: add ARM/AMBARELLA SoC support Long Zhao via B4 Relay
2026-09-04 22:45 ` Linus Walleij
2026-09-04 6:54 ` [PATCH v6 00/13] Ambarella CV75 SoC minimal bring-up Jerome Brunet
2026-09-04 6:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904064542.7D31B1F00A3F@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=longzhao@ambarella.com \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox