Re: [PATCH v4 1/4] firmware: raspberrypi: reorder rpi_firmware_property_tag enum

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch claims to reorder the `rpi_firmware_property_tag` enum by tag values but introduces a new sorting error by moving higher values immediately before lower ones.
--

commit 5b5e3e4d76c8fceb817f997acacf1b16bf561c0e
Author: Gregor Herburger <gregor.herburger@linutronix.de>

firmware: raspberrypi: reorder rpi_firmware_property_tag enum

This patch reorders the tags in the rpi_firmware_property_tag enum to
sort them by their tag values. It claims no functional change is intended.

> diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h
> index 975bef529854a..8ad1cdbf5e9f5 100644
> --- a/include/soc/bcm2835/raspberrypi-firmware.h
> +++ b/include/soc/bcm2835/raspberrypi-firmware.h

[ ... ]

> @@ -125,10 +125,10 @@ enum rpi_firmware_property_tag {
>  	RPI_FIRMWARE_FRAMEBUFFER_SET_VIRTUAL_OFFSET =         0x00048009,
>  	RPI_FIRMWARE_FRAMEBUFFER_SET_OVERSCAN =               0x0004800a,
>  	RPI_FIRMWARE_FRAMEBUFFER_SET_PALETTE =                0x0004800b,
> -	RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF =               0x0004801f,
> -	RPI_FIRMWARE_FRAMEBUFFER_SET_GPIOVIRTBUF =            0x00048020,
>  	RPI_FIRMWARE_FRAMEBUFFER_SET_VSYNC =                  0x0004800e,
>  	RPI_FIRMWARE_FRAMEBUFFER_SET_BACKLIGHT =              0x0004800f,
> +	RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF =               0x0004801f,
> +	RPI_FIRMWARE_FRAMEBUFFER_SET_GPIOVIRTBUF =            0x00048020,
>  
>  	RPI_FIRMWARE_VCHIQ_INIT =                             0x00048010,
>  

[Severity: Medium]
The commit message mentions that the enum is being ordered by tag values,
but does this actually break the ordering for these values?

The new placement moves RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF (0x0004801f)
and RPI_FIRMWARE_FRAMEBUFFER_SET_GPIOVIRTBUF (0x00048020) immediately before
RPI_FIRMWARE_VCHIQ_INIT (0x00048010) in rpi_firmware_property_tag.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-rpi-tryboot-v4-0-fdee8bc53ff7@linutronix.de?part=1