Re: [PATCH v2] arm64: dts: broadcom: bcm2712-rpi-5-b: add spi0 interface

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Device tree compilation fails due to an undefined phandle reference to `rp1_spi0`.
--

commit 330478d6863965c56268ce6533d5e3b957169da2
Author: Gregor Herburger <gregor.herburger@linutronix.de>

arm64: dts: broadcom: bcm2712-rpi-5-b: add spi0 interface

This commit adds the rp1_spi0 node and its pinctrl node to the bcm2712-rpi-5-b
devicetree to route spi0 to the pin header.

Link to v1: https://patch.msgid.link/20260811-bcm2712-spi-v1-0-4c1708d354bb@linutronix.de

> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> index 0fc57e72632ed..0de3d78100a5d 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts

[ ... ]

> @@ -94,6 +108,14 @@ &rp1_i2c6 {
>  	pinctrl-names = "default";
>  };
>  
> +&rp1_spi0 {

[Severity: Low]
Will this cause the device tree compiler (dtc) to fail with a "Reference to
non-existent node or label" error?

It looks like the rp1_spi0 label is undefined in this revision. The patch
notes mention dropping the first patch because it was already applied, but it
seems the prerequisite patch providing the rp1_spi0 base node is missing from
the tree at this revision.

> +	pinctrl-0 = <&rp1_spi0_default_state &rp1_spi0_cs_default_state>;
> +	pinctrl-names = "default";
> +
> +	num-cs = <2>;
> +	cs-gpios = <&rp1_gpio 8 GPIO_ACTIVE_LOW &rp1_gpio 7 GPIO_ACTIVE_LOW>;
> +};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-bcm2712-spi-v2-1-6f8fdfb030bc@linutronix.de?part=1