From: sashiko-bot@kernel.org
To: "Hongyang Zhao" <hongyang.zhao@thundersoft.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 6/6] arm64: dts: qcom: qcs6490-rubikpi3: Add audio support
Date: Fri, 04 Sep 2026 10:59:44 +0000 [thread overview]
Message-ID: <20260904105944.958E21F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260904-rubikpi-next-20260605-v3-6-f49146d85af3@thundersoft.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Undefined pinctrl labels used in the sound node cause device tree compilation failure.
--
commit d72f2352a4f5bf62c0a3db9c3ccca60e51c060c1
Author: Hongyang Zhao <hongyang.zhao@thundersoft.com>
arm64: dts: qcom: qcs6490-rubikpi3: Add audio support
This commit adds audio support for the RubikPi 3 using the AudioReach
firmware path. It describes the ES8316 supplies, MCLK, jack detection,
audio routing, and adds the primary and quaternary MI2S links.
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts
> index 13e8e62f6205a..0322658337ea0 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts
[ ... ]
> @@ -1014,6 +1084,69 @@ &sdhc_2 {
> status = "okay";
> };
>
> +&sound {
> + compatible = "thundercomm,qcs6490-rubikpi3-sndcard";
> + model = "QCS6490-Thundercomm-RubikPi3";
> +
> + pinctrl-0 = <&mi2s0_data0>, <&mi2s0_data1>, <&mi2s0_mclk>,
> + <&mi2s0_sclk>, <&mi2s0_ws>,
[Severity: Low]
Will this device tree compile successfully when using make dtbs?
The primary MI2S pinctrl labels (&mi2s0_data0, &mi2s0_data1, &mi2s0_mclk,
&mi2s0_sclk, and &mi2s0_ws) referenced in the sound node do not appear to be
defined in this file or its included .dtsi files. Referencing an undefined
label usually causes the Device Tree Compiler to abort with a fatal
"Reference to non-existent node or label" error.
> + <&lpass_qua_mi2s_sclk>, <&lpass_qua_mi2s_ws>,
> + <&lpass_qua_mi2s_data>;
> + pinctrl-names = "default";
> +
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-rubikpi-next-20260605-v3-0-f49146d85af3@thundersoft.com?part=6
prev parent reply other threads:[~2026-09-04 10:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 10:02 [PATCH v3 0/6] Add audio support for QCS6490 Rubik Pi 3 Hongyang Zhao
2026-09-04 10:02 ` [PATCH v3 1/6] ASoC: dt-bindings: es8316: Document jack detect inversion Hongyang Zhao
2026-09-04 10:49 ` sashiko-bot
2026-09-04 10:02 ` [PATCH v3 2/6] ASoC: dt-bindings: qcom,sm8250: Add RubikPi 3 sound card Hongyang Zhao
2026-09-04 10:02 ` [PATCH v3 3/6] ASoC: qcom: common: Add generic headset jack helpers Hongyang Zhao
2026-09-04 10:54 ` sashiko-bot
2026-09-04 10:02 ` [PATCH v3 4/6] ASoC: qcom: sc8280xp: Add per-DAI board configuration Hongyang Zhao
2026-09-04 10:58 ` sashiko-bot
2026-09-04 10:02 ` [PATCH v3 5/6] ASoC: qcom: sc8280xp: Add RubikPi 3 sound card support Hongyang Zhao
2026-09-04 10:02 ` [PATCH v3 6/6] arm64: dts: qcom: qcs6490-rubikpi3: Add audio support Hongyang Zhao
2026-09-04 10:59 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904105944.958E21F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hongyang.zhao@thundersoft.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox