Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: Add MSM8952 pinctrl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Inconsistent GPIO pin count constraints and off-by-one error in pins regex.
--

commit ef5e44784233c9aad2c47ecf25b2914eec5fa936
Author: Muzaffer Kadir <muzafferkadir@mainlining.org>

dt-bindings: pinctrl: qcom: Add MSM8952 pinctrl

This commit adds device tree bindings for the TLMM pin controller
found on the Qualcomm MSM8952 platform.

> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8952-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8952-pinctrl.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8952-pinctrl.yaml
[ ... ]
> +properties:
> +  compatible:
> +    const: qcom,msm8952-pinctrl
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  gpio-reserved-ranges:
> +    minItems: 1
> +    maxItems: 61

[Severity: Low]
Should maxItems for gpio-reserved-ranges be 67 instead of 61?

The MSM8952 has 134 pins, meaning there can be up to 67 reserved ranges. The
limit of 61 appears to be a leftover from a 122-pin part like the MSM8916.
This restricts the maximum number of items incorrectly and rejects valid
device trees that need to reserve more ranges up to the correct max of 67.

> +
> +  gpio-line-names:
> +    maxItems: 134

[ ... ]

> +    properties:
> +      pins:
> +        description:
> +          List of gpio pins affected by the properties specified in this
> +          subnode.
> +        items:
> +          oneOf:
> +            - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-2][0-9]|13[0-4])$"

[Severity: Low]
Does this regex incorrectly allow "gpio134" to pass DT validation?

The regex matches up to 13[0-4], which includes "gpio134" (the 135th GPIO).
However, the gpio-line-names property above is correctly restricted to 134
items (indices 0 to 133). 

Since the maximum valid GPIO index is 133, a device tree author specifying
"gpio134" in a configuration node will pass validation but fail at runtime.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-msm8952-pinctrl-v3-0-110515fff513@mainlining.org?part=1