Re: [PATCH 3/7] arm64: dts: qcom: Add Purwa IdeaCentre Mini 01Q8X10

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The device tree leaves the `pmc8380_6_die_temp` ADC channel enabled despite physically removing the corresponding `pmc8380_6` PMIC.
- [Low] The patch inadvertently replaces the composite dtbs rule for `purwa-iot-evk-el2-dtbs` instead of adding the new board's rule alongside it, causing a build failure.
--

commit a1fbbf4379b4719283a1891d22cc069dc0b2dda9
Author: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

arm64: dts: qcom: Add Purwa IdeaCentre Mini 01Q8X10

This patch adds the Purwa SKU of the Lenovo IdeaCentre Mini 01Q8X10. It
provides the Purwa SoC include, firmware paths, and removes the pmc8380_6
nodes that are not physically present on this board.

> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 6c2ac11133ca7..e6105e5790954 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -167,7 +167,8 @@ dtb-$(CONFIG_ARCH_QCOM)	+= msm8998-sony-xperia-yoshino-poplar.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= msm8998-xiaomi-sagit.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= purwa-iot-evk.dtb
>  
> -purwa-iot-evk-el2-dtbs	:= purwa-iot-evk.dtb x1-el2.dtbo
> +purwa-lenovo-ideacentre-mini-01q8x10-el2-dtbs := purwa-lenovo-ideacentre-mini-01q8x10.dtb x1-el2.dtbo

[Severity: Low]
Does this unintentionally remove the composite rule for the existing
purwa-iot-evk-el2 board?

Kbuild will fail with a 'No rule to make target' error when building because
dtb-$(CONFIG_ARCH_QCOM) += purwa-iot-evk-el2.dtb remains slightly further down
in this Makefile, but its underlying composite dtbs definition has been
overwritten here instead of being preserved.

> +dtb-$(CONFIG_ARCH_QCOM)	+= purwa-lenovo-ideacentre-mini-01q8x10.dtb purwa-lenovo-ideacentre-mini-01q8x10-el2.dtb
>  
>  dtb-$(CONFIG_ARCH_QCOM)	+= purwa-iot-evk-el2.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= qcm6490-fairphone-fp5.dtb
> diff --git a/arch/arm64/boot/dts/qcom/purwa-lenovo-ideacentre-mini-01q8x10.dts b/arch/arm64/boot/dts/qcom/purwa-lenovo-ideacentre-mini-01q8x10.dts
> new file mode 100644
> index 0000000000000..9813a570cf690
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/purwa-lenovo-ideacentre-mini-01q8x10.dts
> @@ -0,0 +1,42 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + * Copyright (c) Jens Glathe
> + */
> +
> +/dts-v1/;
> +
> +#include "purwa.dtsi"
> +#include "x1-lenovo-ideacentre-mini-01q8x10.dtsi"
> +
> +/delete-node/ &pmc8380_6;
> +/delete-node/ &pmc8380_6_thermal;

[Severity: Medium]
Since the physical pmc8380_6 PMIC is declared absent and its main nodes are
deleted, does the associated ADC channel pmc8380_6_die_temp also need to be
deleted here?

If the SPMI ADC driver (qcom-spmi-adc5) probes the pre-defined channel and
tries to configure it on a non-existent PMIC, it can lead to SPMI bus
communication timeouts and invalid hwmon reads. Should there be a
/delete-node/ &pmc8380_6_die_temp; added to this block?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905-x1-ideacentre-mini-prettify-v1-0-9a87882973bb@oldschoolsolutions.biz?part=3