Re: [PATCH v4 1/6] dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car X5H PCIe4 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing required `phys` property in device tree schema for R-Car Gen5 PCIe4, and incorrect property name referenced in commit message.
--

commit c9ec2af02aea699681c72cca90dd0320653d84c0
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>

dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car X5H PCIe4 compatible

Document bindings for R-Car X5H (R8A78000) PCIe4 host module.
The R-Car X5H PCIe4 controller no longer includes the PHY register range,
and the PHY is now a separate IP referenced via the 'phy' DT property.

> The R-Car X5H PCIe4 controller does no longer include PHY register
> range, the PHY is now a separate IP and referenced via the 'phy' DT
> property.

[Severity: Medium]
Is the property name in the commit message correct?

The standard property name for PHY references is phys, not phy. A property
named phy would be rejected by unevaluatedProperties: false during schema
validation if actually used.

> diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
> index 64f456c6a75a1..9767a52f3904e 100644
> --- a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml
[ ... ]
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,rcar-gen5-pcie4
> +    then:
> +      properties:
> +        reg:
> +          maxItems: 6
> +
> +        reg-names:
> +          items:
> +            - const: dbi
> +            - const: dbi2
> +            - const: atu
> +            - const: dma
> +            - const: app
> +            - const: config

[Severity: Medium]
Since the Gen5 PCIe4 controller removes the internal phy register region and
mandates an external PHY, should this conditional block also add the standard
phys property to a required list?

Without enforcing this requirement in the schema, incomplete device trees
missing the phys property will pass validation but cause runtime failures
when the driver attempts to retrieve the PHY using devm_phy_get(dev, NULL).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905212649.360498-1-marek.vasut+renesas@mailbox.org?part=1