Re: [PATCH 2/2] arm64: dts: allwinner: Add SPC Glee 10.1 A64

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing sun50i-a64-cpu-opp.dtsi include breaks CPUfreq and thermal cooling
- [Medium] Missing usb_power_supply enablement breaks USB charger detection
--

commit bdf7f6917d0d11f91550b9e8dcb96f41a0c5bde4
Author: Juan Carlos Gutiérrez Lavado <jcarlosgl96@proton.me>

arm64: dts: allwinner: Add SPC Glee 10.1 A64

Add support for the SPC Glee 10.1 tablet based on the Allwinner A64. It
describes essential components including the PMIC, microSD, UART, and USB.

> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-spc-glee.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-spc-glee.dts
> new file mode 100644
> index 0000000000000..1ca7c36de65e2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-spc-glee.dts
> @@ -0,0 +1,123 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (C) 2026 SPC Glee A64 Linux contributors
> + */
> +
> +/dts-v1/;
> +
> +#include "sun50i-a64.dtsi"

[Severity: Medium]
Does this board device tree omission break CPUfreq and thermal cooling?

By omitting the sun50i-a64-cpu-opp.dtsi include here, the board device tree
includes the base SoC definitions but lacks the CPU operating points required
for cpufreq and thermal management.

During boot, the thermal and cpufreq-dt drivers will probe the CPU nodes but
find no operating-points-v2 property. This can cause the cpufreq driver to
abort initialization, leaving the CPU pinned to the fixed bootloader
frequency and preventing the registration of CPU cooling devices. The thermal
framework would then be unable to actively throttle the CPU, which may risk
thermal trip shutdowns under load and degrade battery life.

Should the sun50i-a64-cpu-opp.dtsi file be included here?

[ ... ]

> +&usb_otg {
> +	dr_mode = "peripheral";
> +	status = "okay";
> +};
> +
> +&usbphy {
> +	status = "okay";
> +};

[Severity: Medium]
Does enabling the usbphy without enabling the usb_power_supply break USB
charger detection?

The usbphy node is enabled, but the required &usb_power_supply node (which
monitors VBUS on the PMIC) is completely omitted and not linked via
usb0_vbus_power-supply.

Because the AXP803 PMIC's USB power supply node defaults to disabled in
axp803.dtsi, failing to override it to okay in the board file means the AXP
USB power supply driver (axp20x_usb_power) will not probe.

As a result, userspace tools will not know when a USB charger is connected.
Furthermore, without being linked to the usbphy, the USB PHY driver will
forcefully assume VBUS is always present, which could cause erratic USB
peripheral state transitions when unplugged.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906-b4-spc-glee-a64-v1-v1-0-621df2155e31@proton.me?part=2