Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Cc: Vinod Koul <vkoul@kernel.org>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	 Abel Vesa <abelvesa@kernel.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	 Bartosz Golaszewski <brgl@kernel.org>,
	Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>,
	 linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH 2/4] dt-bindings: phy: qcom,snps-eusb2-phy: Document the Nord eUSB2 PHY
Date: Mon, 7 Sep 2026 08:12:21 +0200	[thread overview]
Message-ID: <20260907-eminent-silky-dog-98e56a@quoll> (raw)
In-Reply-To: <20260901095055.42229-3-shengchao.guo@oss.qualcomm.com>

On Tue, Sep 01, 2026 at 05:50:53PM +0800, Shawn Guo wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> 
> Add a compatible for the eUSB2 PHY found on the Qualcomm Nord SoC.
> It is compatible with the sm8550 eUSB2 PHY.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>

This should be squashed with previous patch. Why reset is being made
optional? The change itself had not meaning, no sense. It was made
optional as part of qcom,nord-snps-eusb2-phy requirements... unless it
was all about drivers?

Best regards,
Krzysztof


  reply	other threads:[~2026-09-07  6:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  9:50 [PATCH 0/4] phy: qcom: Add USB PHY support for Nord SoC Shawn Guo
2026-09-01  9:50 ` [PATCH 1/4] dt-bindings: phy: qcom,snps-eusb2-phy: Make resets optional Shawn Guo
2026-09-07  6:11   ` Krzysztof Kozlowski
2026-09-01  9:50 ` [PATCH 2/4] dt-bindings: phy: qcom,snps-eusb2-phy: Document the Nord eUSB2 PHY Shawn Guo
2026-09-07  6:12   ` Krzysztof Kozlowski [this message]
2026-09-01  9:50 ` [PATCH 3/4] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Document the Nord QMP PHY Shawn Guo
2026-09-07  6:13   ` Krzysztof Kozlowski
2026-09-01  9:50 ` [PATCH 4/4] phy: qcom: qmp-combo: Add USB3+DP PHY support for Nord Shawn Guo
2026-09-01 10:03   ` sashiko-bot
2026-09-01 12:12   ` Abel Vesa
2026-09-01 12:33   ` Krishna Kurapati

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907-eminent-silky-dog-98e56a@quoll \
    --to=krzk@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=krishna.kurapati@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=shengchao.guo@oss.qualcomm.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox