From: Conor Dooley <conor@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: devicetree@vger.kernel.org, Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Robinson <pbrobinson@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible
Date: Mon, 7 Sep 2026 17:54:12 +0100 [thread overview]
Message-ID: <20260907-unnamable-geography-d04f61df0fe5@spud> (raw)
In-Reply-To: <20260905000919.155694-1-rosenp@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]
On Fri, Sep 04, 2026 at 05:09:19PM -0700, Rosen Penev wrote:
> The pca9655 is the On Semi variant of the pca9555 16-bit I2C GPIO
> expander and is register-compatible with it. The addition of the
> compatible in the driver missed the documentation update.
The commit message makes it sound like this device should use a
fallback. Why doesn't it? Either it should, or the commit message needs
an update.
pw-bot: changes-requested
Thanks,
Conor.
>
> Fixes: 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi pca9655")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> index 4631388a7d91..563f61e6e543 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-pca95xx.yaml
> @@ -67,6 +67,7 @@ properties:
> - nxp,pcal9555a
> - onnn,cat9554
> - onnn,pca9654
> + - onnn,pca9655
> - ti,pca6107
> - ti,pca9536
> - ti,tca6408
> --
> 2.55.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-09-07 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 0:09 [PATCH] dt-bindings: gpio: pca95xx: add onnn,pca9655 compatible Rosen Penev
2026-09-07 16:54 ` Conor Dooley [this message]
2026-09-08 7:37 ` Bartosz Golaszewski
2026-09-08 17:03 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907-unnamable-geography-d04f61df0fe5@spud \
--to=conor@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbrobinson@gmail.com \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox