Re: [PATCH 1/2] dt-bindings: hwmon: pmbus: Add Infineon tda38740 and tda38725

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `$id` and `$schema` properties use the `https://` protocol instead of the required `http://` prefix.
- [Low] The mandatory `maintainers` property is missing from the top-level schema.
--

commit 394e1f6fb8099cdca94075856e1923221cb81dae
Author: Colin Huang <u8813345@gmail.com>

dt-bindings: hwmon: pmbus: Add Infineon tda38740 and tda38725

This commit adds devicetree bindings for the Infineon TDA38740 and
TDA38725 synchronous buck regulators. The hardware uses a PMBus interface
and the binding documents custom properties such as vout scaling.

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml
> new file mode 100644
> index 0000000000000..02380c09c5f55
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: https://devicetree.org/schemas/hwmon/pmbus/infineon,tda38740.yaml#
> +$schema: https://devicetree.org/meta-schemas/core.yaml#

[Severity: Medium]
Does using the https:// protocol instead of http:// for the $id and $schema
fields break the schema cross-reference system? Modern dt-schema validation
tools rely on exact string matches for these URIs, and an incorrect prefix
might cause dt_binding_check to report misleading errors or silently skip
validation.

> +
> +title: Infineon TDA38740 and TDA38725 PMBus Synchronous Buck Regulator

[Severity: Low]
Is the mandatory maintainers property missing from the top-level schema?
Device tree schema files validated against core.yaml are required to specify
a maintainers array (typically right after the title or description), and
omitting it will likely cause dt_binding_check to report a validation
failure.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-add-tda38740-and-tda38725-v1-0-e2db1b2566b1@gmail.com?part=1