From: sashiko-bot@kernel.org
To: "Shashank Maurya" <shashank.maurya@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: rpi-panel-v2: Add required vcc-supply property
Date: Mon, 07 Sep 2026 05:55:11 +0000 [thread overview]
Message-ID: <20260907055512.443A81F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260907-rpi_reg-v2-1-0c59aa60d31f@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Making `vcc-supply` a strictly required property breaks existing in-tree device trees and ABI compatibility.
--
commit 1cfb28295a002af7450cc6c89daa817a9abfb4b0
Author: Shashank Maurya <shashank.maurya@oss.qualcomm.com>
dt-bindings: regulator: rpi-panel-v2: Add required vcc-supply property
This commit introduces a vcc-supply property to the Raspberry Pi 7"
touchscreen panel V2 regulator binding. It specifies the regulator supplying
power to the panel controller and marks it as a required property.
> diff --git a/Documentation/devicetree/bindings/regulator/raspberrypi,7inch-touchscreen-panel-regulator-v2.yaml b/Documentation/devicetree/bindings/regulator/raspberrypi,7inch-touchscreen-panel-regulator-v2.yaml
> index 37b9ed371b67d..a6195e53be16b 100644
> --- a/Documentation/devicetree/bindings/regulator/raspberrypi,7inch-touchscreen-panel-regulator-v2.yaml
> +++ b/Documentation/devicetree/bindings/regulator/raspberrypi,7inch-touchscreen-panel-regulator-v2.yaml
[ ... ]
> @@ -43,6 +46,7 @@ required:
> - gpio-controller
> - "#gpio-cells"
> - "#pwm-cells"
> + - vcc-supply
[Severity: Critical]
Does making this property strictly required introduce regressions for
existing in-tree device trees?
Looking at the current tree,
arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk-rpi-display-2.dtsi
uses this binding but does not define vcc-supply:
arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk-rpi-display-2.dtsi:
mcu: gpio@45 {
compatible = "raspberrypi,touchscreen-panel-regulator-v2";
reg = <0x45>;
gpio-controller;
...
};
Since vcc-supply is now unconditionally required, wouldn't builds
incorporating this device tree now fail dtbs_check validation?
Could this be made optional to preserve ABI compatibility, or should the
existing device tree nodes be updated in the same patch series to prevent
breakages?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-rpi_reg-v2-0-0c59aa60d31f@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-09-07 5:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 5:46 [PATCH v2 0/2] regulator: rpi-panel-v2: Add required vcc-supply Shashank Maurya
2026-09-07 5:46 ` [PATCH v2 1/2] dt-bindings: regulator: rpi-panel-v2: Add required vcc-supply property Shashank Maurya
2026-09-07 5:55 ` sashiko-bot [this message]
2026-09-07 13:24 ` Dave Stevenson
2026-09-07 17:10 ` Conor Dooley
2026-09-11 5:42 ` Shashank Maurya
2026-09-07 5:46 ` [PATCH v2 2/2] regulator: rpi-panel-v2: Add required vcc-supply support Shashank Maurya
2026-09-07 5:51 ` sashiko-bot
2026-09-07 6:02 ` Marek Vasut
2026-09-07 13:21 ` Dave Stevenson
2026-09-07 17:06 ` Conor Dooley
2026-09-07 17:09 ` Mark Brown
2026-09-07 18:04 ` Conor Dooley
2026-09-11 5:16 ` Shashank Maurya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907055512.443A81F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shashank.maurya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox