Re: [PATCH v5 3/3] arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant DT file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Ambiguous root compatible string for the NAND variant prevents proper board identification.
--

commit 054f8927949f274ca03510708d77e6e740a88b02
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant DT file

Add DT file for the NAND variant and include it in the Makefile.

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts
> new file mode 100644
> index 0000000000000..1145fcf0a3025
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +/dts-v1/;
> +
> +#include "ipq5210-rdp504-common.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. IPQ5210 RDP504 (NAND)";
> +	compatible = "qcom,ipq5210-rdp504", "qcom,ipq5210";

[Severity: Medium]
Will this compatible string prevent bootloaders from selecting the correct DTB
from a multi-DTB image?

Bootloaders that rely on the root compatible string to select the correct
Device Tree Blob (DTB) from a multi-DTB image (such as a FIT image) cannot
deterministically distinguish between this newly added NAND variant and the
existing eMMC variant, because both define the exact same compatible string
("qcom,ipq5210-rdp504").

Since the board must be physically reworked to change from eMMC to NAND,
loading the wrong DTB could lead to pin conflicts and an inability to access
the storage medium.

Should the NAND variant declare a distinct, unique compatible string, such as
"qcom,ipq5210-rdp504-nand"?

> +};
> +
> +&qpic_nand {
> +	status = "okay";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-08-dts-v5-0-584e5ab50b40@oss.qualcomm.com?part=3