Re: [PATCH v2 10/11] dt-bindings: sound: qcom: add Tambora WCD9378 SDCA codec

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The vendor-specific compatible string violates the strict SoundWire bus schema pattern constraint.
--

commit 21a3dc5b2580f691e90cc1ec8c4f97f3b064cd1b
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

dt-bindings: sound: qcom: add Tambora WCD9378 SDCA codec

This commit introduces the device tree binding schema for the Qualcomm WCD9378
(Tambora) SoundWire codec in SDCA compute mode.

> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9378-sdw.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd9378-sdw.yaml
> new file mode 100644
> index 0000000000000..9a6c309018edd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd9378-sdw.yaml
[ ... ]
> +properties:
> +  compatible:
> +    items:
> +      - const: qcom,wcd9378c
> +      - const: sdw20217011000

[Severity: Low]
Does this vendor-specific compatible string pass validation against the
SoundWire bus schema?

When dt-schema processes a device tree using this binding, the parent node
matches soundwire-controller.yaml. That schema dictates that child nodes
matching ^.*@[0-9a-f],[0-9a-f]$ must have a compatible property matching the
regex ^sdw[0-9a-f]{1}[0-9a-f]{4}[0-9a-f]{4}[0-9a-f]{2}$.

Because dt-schema enforces string constraints on all items within a
compatible string array, the presence of the qcom,wcd9378c string appears
to trigger a validation failure during make dt_binding_check.

Should soundwire-controller.yaml be updated to explicitly allow standard
vendor,device strings alongside MIPI SoundWire IDs, or does this vendor
string need to be removed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907083727.733705-1-srinivas.kandagatla@oss.qualcomm.com?part=10