Re: [PATCH v7 2/4] dt-bindings: input: touchscreen: st,stmfts: Introduce STM FTS5

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The conditional block restricting 'mode-switch-gpios' is missing the 'contains' keyword under 'compatible', which will cause it to erroneously evaluate to false for all devices and block the use of 'mode-switch-gpios' entirely.
--

commit 30e556decedf2eedf468c2bb05ec4af06f53437e
Author: David Heidelberg <david@ixit.cz>

dt-bindings: input: touchscreen: st,stmfts: Introduce STM FTS5

This commit introduces support for the STM FTS5 touchscreen variant to the
existing st,stmfts device tree binding. It adds the new compatible string
and introduces an optional mode-switch-gpios property specific to the FTS5
variant.

> diff --git a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml
> index 64c4f24ea3dd0..3de4bc5cd3f78 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/st,stmfts.yaml
[ ... ]
> @@ -51,6 +54,17 @@ required:
>    - interrupts
>    - vdd-supply
>  
> +allOf:
> +  - $ref: touchscreen.yaml#
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            const: st,stmfts5

[Severity: Medium]
Does this compatible string check need a contains directive? Because the
compatible property is globally evaluated as an array of strings in DT
schemas, using a strict const match here will always fail.

As a result, the not wrapper will always evaluate to true, unconditionally
applying the mode-switch-gpios: false restriction to all nodes, including
st,stmfts5. Valid device trees using st,stmfts5 with mode-switch-gpios
will likely fail dt_binding_check.

Should this be written as contains: const: st,stmfts5 instead?

> +    then:
> +      properties:
> +        mode-switch-gpios: false
> +
>  unevaluatedProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-stmfts5-v7-0-4a53381cd038@ixit.cz?part=2