Re: [PATCH v2 5/6] arm64: dts: microchip: ev23x71a: enable QSPI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Deprecated `#address-cells` and `#size-cells` properties used in MTD flash node.
--

commit f35337ebba269a3b16d4cec0dd59b117f17e49c6
Author: Robert Marko <robert.marko@sartura.hr>

arm64: dts: microchip: ev23x71a: enable QSPI

This commit enables the QSPI controller and describes the onboard SPI NOR
flash for the Microchip ev23x71a board.

> diff --git a/arch/arm64/boot/dts/microchip/lan9696-ev23x71a.dts b/arch/arm64/boot/dts/microchip/lan9696-ev23x71a.dts
> index 4012ea7d07bbd..985ca31e74e76 100644
> --- a/arch/arm64/boot/dts/microchip/lan9696-ev23x71a.dts
> +++ b/arch/arm64/boot/dts/microchip/lan9696-ev23x71a.dts
> @@ -463,6 +463,21 @@ phy27: phy@27 {
>  	};
>  };
>  
> +&qspi0 {
> +	status = "okay";
> +
> +	flash@0 {
> +		compatible = "jedec,spi-nor";
> +		reg = <0>;
> +		spi-max-frequency = <100000000>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;

[Severity: Low]
Does this flash node need the #address-cells and #size-cells properties?

Since this flash@0 node does not define any subnodes (such as partitions
or otp), these properties serve no purpose here. The MTD devicetree bindings
in Documentation/devicetree/bindings/mtd/mtd.yaml explicitly mark these
properties as deprecated at the root of the MTD node.

Compiling the devicetree with dtbs_check will likely trigger a schema
warning due to this.

> +		spi-tx-bus-width = <1>;
> +		spi-rx-bus-width = <4>;
> +		m25p,fast-read;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907132617.1198548-1-robert.marko@sartura.hr?part=5