From: sashiko-bot@kernel.org
To: "Shujath Mohd" <shujath@outlook.in>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-sony: Add battery properties
Date: Mon, 07 Sep 2026 16:06:43 +0000 [thread overview]
Message-ID: <20260907160644.655A61F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <PUZPR01MB51411878AC2B70673F77ED38C3B22@PUZPR01MB5141.apcprd01.prod.exchangelabs.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added `simple-battery` nodes are orphaned and will be ignored by the power supply framework because no charger or fuel gauge references them.
--
commit b9560b36965d2ab30a517952de24fe50774a59c5
Author: Shujath Mohd <shujath@outlook.in>
arm64: dts: qcom: sdm845-sony: Add battery properties
This commit adds simple-battery nodes for the Xperia XZ2, XZ2 Compact,
and XZ3 device trees to specify design capacity and voltage limits.
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts
> index 6e65909ab582e..16e676ac96304 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akari.dts
> @@ -10,6 +10,13 @@
> / {
> model = "Sony Xperia XZ2";
> compatible = "sony,akari-row", "qcom,sdm845";
> +
> + battery: battery {
> + compatible = "simple-battery";
> + charge-full-design-microamp-hours = <3180000>;
[Severity: Medium]
Are these newly added battery nodes orphaned?
During initialization, the power_supply subsystem relies on
power_supply_get_battery_info() to parse battery information. This function
explicitly searches for a monitored-battery = <&battery>; phandle in the
consumer node (such as a PMIC charger or fuel gauge).
Since there is no device tree node referencing this battery label, the
parsing is skipped entirely and the power supply drivers will fall back to
hardware defaults.
> + voltage-min-design-microvolt = <3400000>;
> + voltage-max-design-microvolt = <4245000>;
> + };
> };
>
> &panel {
[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
> index 82e59e4533549..3bf9db9632991 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts
> @@ -26,6 +26,13 @@ ts_vddio_supply: ts-vddio-regulator {
> enable-active-high;
> regulator-boot-on;
> };
> +
> + battery: battery {
> + compatible = "simple-battery";
> + charge-full-design-microamp-hours = <3330000>;
[Severity: Medium]
As with the akari device tree, does this node also lack the required
monitored-battery phandle linkage from a charger or fuel gauge node?
> + voltage-min-design-microvolt = <3400000>;
> + voltage-max-design-microvolt = <4245000>;
> + };
> };
>
> &ibb {
[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-apollo.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-apollo.dts
> index dc15ab1a27165..013987184b398 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-apollo.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-apollo.dts
> @@ -10,6 +10,13 @@
> / {
> model = "Sony Xperia XZ2 Compact";
> compatible = "sony,apollo-row", "qcom,sdm845";
> +
> + battery: battery {
> + compatible = "simple-battery";
> + charge-full-design-microamp-hours = <2870000>;
[Severity: Medium]
Will this battery node also be ignored by the power supply framework due
to the missing consumer phandle?
> + voltage-min-design-microvolt = <3400000>;
> + voltage-max-design-microvolt = <4245000>;
> + };
> };
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/PUZPR01MB51411878AC2B70673F77ED38C3B22@PUZPR01MB5141.apcprd01.prod.exchangelabs.com?part=1
prev parent reply other threads:[~2026-09-07 16:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 15:58 [PATCH] arm64: dts: qcom: sdm845-sony: Add battery properties Shujath Mohd
2026-09-07 16:06 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907160644.655A61F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shujath@outlook.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox