Re: [PATCH v1 3/5] ASoC: codec: pcm1681: Enable system clock before regmap access

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Casting clk_disable_unprepare to (void (*)(void *)) causes a fatal Control-Flow Integrity (kCFI) violation on execution.
--

commit e63e11f267cb1c89c4801467a10adb890c3c4c31
Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

ASoC: codec: pcm1681: Enable system clock before regmap access
    
This commit adds optional clock support to the PCM1681 driver by acquiring
the "sck" clock and enabling it during probe. It registers a managed cleanup
action to disable it during device removal or probe failure.

> diff --git a/sound/soc/codecs/pcm1681.c b/sound/soc/codecs/pcm1681.c
> index 60fdbe5c4e054..cfe549176d14f 100644
> --- a/sound/soc/codecs/pcm1681.c
> +++ b/sound/soc/codecs/pcm1681.c

[ ... ]

> @@ -311,6 +313,22 @@ static int pcm1681_i2c_probe(struct i2c_client *client)
>  	if (!priv)
>  		return -ENOMEM;
>  
> +	priv->sclk = devm_clk_get_optional(&client->dev, "sck");
> +	if (IS_ERR(priv->sclk))
> +		return dev_err_probe(&client->dev, PTR_ERR(priv->sclk),
> +				     "Failed to get sck\n");
> +
> +	ret = clk_prepare_enable(priv->sclk);
> +	if (ret)
> +		return dev_err_probe(&client->dev, ret,
> +				     "Failed to enable sck\n");
> +
> +	ret = devm_add_action_or_reset(&client->dev,
> +				       (void (*)(void *))clk_disable_unprepare,
> +				       priv->sclk);

[Severity: High]
Does casting clk_disable_unprepare to (void (*)(void *)) cause a fatal
Control-Flow Integrity (kCFI) violation on execution?

When the kernel is compiled with Clang's kCFI (CONFIG_CFI_CLANG), calling a
function through a pointer with a mismatched signature (from
void (*)(struct clk *) to void (*)(void *)) results in a type hash mismatch.

This triggers an immediate kernel panic when the devres API executes this
callback during driver unbind, remove, or on probe failure after the clock
is enabled.

> +	if (ret)
> +		return ret;
> +
>  	priv->regmap = devm_regmap_init_i2c(client, &pcm1681_regmap);
>  	if (IS_ERR(priv->regmap)) {
>  		ret = PTR_ERR(priv->regmap);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-nord-asoc-driver-support-v1-0-997d3b20cf43@oss.qualcomm.com?part=3