From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] ARM: dts: BCM5301X: AC56U: add nvram node
Date: Mon, 07 Sep 2026 19:46:24 +0000 [thread overview]
Message-ID: <20260907194624.EC6791F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260907194032.20042-1-rosenp@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `gmac0` node override at the top level of the DTS file is missing the `&` ampersand prefix, causing a syntax error and build failure.
--
commit b3e9863f98ae6b1a8bec5d68e2e1b2a375393644
Author: Rosen Penev <rosenp@gmail.com>
ARM: dts: BCM5301X: AC56U: add nvram node
This patch adds an nvram node to the AC56U device tree based on bootlog
sizes. It also sets up the nvmem cells for the gmac0 node to supply its
mac address.
> diff --git a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> index c80ac16ad9496..550cc67f5ba6c 100644
> --- a/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm4708-asus-rt-ac56u.dts
[ ... ]
> @@ -92,3 +101,8 @@ button-wps {
> &usb3_phy {
> status = "okay";
> };
> +
> +gmac0 {
[Severity: Low]
Is this missing an ampersand prefix? Overriding an existing node from the top
level of the device tree requires an ampersand like &gmac0, otherwise this
will cause a syntax error in the Device Tree Compiler and break the build.
> + nvmem-cells = <&et0macaddr 0>;
> + nvmem-cell-names = "mac-address";
> +};
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260907194032.20042-1-rosenp@gmail.com?part=1
prev parent reply other threads:[~2026-09-07 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 19:40 [PATCH] ARM: dts: BCM5301X: AC56U: add nvram node Rosen Penev
2026-09-07 19:46 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907194624.EC6791F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox