Re: [PATCH v2 1/2] dt-bindings: iio: light: add as7343

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `#include <dt-bindings/gpio/gpio.h>` for `GPIO_ACTIVE_LOW` in the dt-binding example.
--

commit 6fee3afaa3c4f47b1efbffef07588793c6bc1b7e
Author: Chang Yu <marcus.yu.56@gmail.com>

dt-bindings: iio: light: add as7343

This commit adds a new device tree binding for the AMS AS7343 14-channel
multi-spectral sensor.

> diff --git a/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml
> new file mode 100644
> index 0000000000000..b06d445b92b3d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        multispectral-sensor@39 {
> +            compatible = "ams,as7343";
> +            reg = <0x39>;
> +            interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
> +            vdd-supply = <&vdd_regulator>;
> +            ams,led-current-microamp = <14000>;
> +            gpios = <&gpio0 6 GPIO_ACTIVE_LOW>;

[Severity: Low]
Does this examples block need to include <dt-bindings/gpio/gpio.h>?

This gpios assignment relies on the GPIO_ACTIVE_LOW macro. Without the
corresponding header included at the top of the examples block, the dtc
compiler will fail with a syntax error during make dt_binding_check
because the unexpanded macro will be treated as an invalid token inside
the cell array.

> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907210042.32552-1-marcus.yu.56@gmail.com?part=1