From: sashiko-bot@kernel.org
To: "James Hilliard" <james.hilliard1@gmail.com>
Cc: mfd@lists.linux.dev, lee@kernel.org, robh@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v11 2/2] mfd: ac200: Add X-Powers AC200 support
Date: Mon, 07 Sep 2026 21:09:12 +0000 [thread overview]
Message-ID: <20260907210912.8C2E11F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260907-submit-ac200-mfd-v11-2-58dd9dc7f69a@gmail.com>
> The X-Powers AC200 is a mixed-signal companion IC with a paged register
> map accessed over I2C.
>
> Enable and rate-lock the shared input clock, retain the vendor resume
> path's 40 ms wait before creating the regmap and accessing registers, and
> deassert the common reset. No minimum delay is documented. Set only the
> deassert bit instead of forcing a reset cycle, avoiding a chip-wide reset
> of unrelated function registers. Leave the common reset deasserted during
> driver removal and system shutdown; function drivers own their block
> resets. Supplier unbind still tears down linked consumers and releases
> the provider's clock references.
>
> Cache only the common page selector. Individual functions can reset
> independently and invalidate their other registers, so leave all
> functional registers volatile.
> [ ... ]
> ancillary package-control access.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-submit-ac200-mfd-v11-0-58dd9dc7f69a@gmail.com?part=2
prev parent reply other threads:[~2026-09-07 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 21:03 [PATCH v11 0/2] mfd: add X-Powers AC200 support James Hilliard
2026-09-07 21:03 ` [PATCH v11 1/2] dt-bindings: mfd: x-powers: Add AC200 James Hilliard
2026-09-07 21:07 ` sashiko-bot
2026-09-08 18:05 ` Conor Dooley
2026-09-08 21:38 ` James Hilliard
2026-09-08 22:02 ` Conor Dooley
2026-09-07 21:03 ` [PATCH v11 2/2] mfd: ac200: Add X-Powers AC200 support James Hilliard
2026-09-07 21:09 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907210912.8C2E11F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox