From: sashiko-bot@kernel.org
To: "Karthik S" <karthik.s@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v1 2/2] pinctrl: qcom: Add qcs615 lpass lpi pinctrl driver
Date: Tue, 08 Sep 2026 08:11:42 +0000 [thread overview]
Message-ID: <20260908081142.BE8B91F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260908075854.3015560-3-karthik.s@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused static arrays (`gpio0_pins` through `gpio31_pins`) will cause compiler warnings
--
commit 72e924992eb3de90f14daba573a913e0c3530e32
Author: Karthik S <karthik.s@oss.qualcomm.com>
pinctrl: qcom: Add qcs615 lpass lpi pinctrl driver
This commit adds a pinctrl driver to support pin configuration for the
Low Power Audio SubSystem (LPASS) Low Power Island (LPI) on QCS615.
It introduces a separate pin controller block specifically intended to
control audio pins.
> diff --git a/drivers/pinctrl/qcom/pinctrl-qcs615-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-qcs615-lpass-lpi.c
> new file mode 100644
> --- /dev/null
> +++ b/drivers/pinctrl/qcom/pinctrl-qcs615-lpass-lpi.c
[ ... ]
> +static int gpio8_pins[] = { 8 };
> +static int gpio9_pins[] = { 9 };
[ ... ]
> +static int gpio31_pins[] = { 31 };
[Severity: Low]
Are these static integer arrays (gpio0_pins through gpio31_pins) necessary?
They appear to be unreferenced in this source file and will cause unused
variable warnings.
Unlike the top-level MSM pinctrl driver's PINGROUP macro, the LPASS LPI
framework's LPI_PINGROUP macro does not seem to utilize these arrays.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260908075854.3015560-1-karthik.s@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-09-08 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 7:58 [PATCH v1 0/2] pinctrl: qcom: Add QCS615 LPASS LPI pinctrl support Karthik S
2026-09-08 7:58 ` [PATCH v1 1/2] dt-bindings: pinctrl: qcom: Add QCS615 LPASS LPI pinctrl bindings Karthik S
2026-09-08 7:58 ` [PATCH v1 2/2] pinctrl: qcom: Add qcs615 lpass lpi pinctrl driver Karthik S
2026-09-08 8:11 ` sashiko-bot [this message]
2026-09-08 13:02 ` Konrad Dybcio
2026-09-08 14:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908081142.BE8B91F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=karthik.s@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox