From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF92B34F270 for ; Tue, 8 Sep 2026 08:01:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788854491; cv=none; b=tOsDa5SU/5KMPKkauYfvYYhDJWikmbfMnHDNWriekGSN2Qxmd2zV5wAxkrzerZoz4SDLAWaRqM7suS2TRB21LP6pn36qUPJe0z1JXEzAN1tSQOtP04vLCwoLZdETea95ZkPRq2PRJwz1E6+ohpmXi6SpDdUXiBrySkAWiumHS8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788854491; c=relaxed/simple; bh=z623OSOb6uOq/0jf/wjVHRqGtaT8xKUfonIY60W2fx8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=M74zBh0kKxMq54S3S43oW6XKYUOulojIXgHe/FGbwz5XC1Txpbdg8qfz7opRx5juui89yvzEt488AG5V0zb4uB0U37Ro1AcF2IdjfuprXXFuXFS1ACOmYjPaOZX73uj6beil35T53I1L8K5Gpp+wXiCa0J8hzVCTLlvsfrAmjCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sAOUHU77; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sAOUHU77" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-49ccfbe062eso41422195e9.3 for ; Tue, 08 Sep 2026 01:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788854488; x=1789459288; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=xDQnWL+09MRQg3JHhpcIAGJ0gQMTwutt9tXBZmD4GyU=; b=sAOUHU77g8AmRqosJMUKGE6wp56zgS3feonGPeYq1q4FY/1YCdgjZS5gEvJxmufqxJ 7yd7AVxh4X8GOrnw7+c8/2YcgrFtCIJ8+cnoNrMFp51upPRyR/Yz6skp1azin1z1JiPP YpbWNAmD2oG7FXXgcFUZrlMwcHOpr7Rtp8Pa+tSG+Jvwd8wrmGiP08Db39A7fAY5/gRA gwTiuRfDK0Eg9UQcfuXD+XubUE6EzgqpHRWjHrywX90YCHsjYAGMRPYKe16RiCWnsUst 6F3sY8vcstNKstWitiS7eMYoC9zi/JUFBLqv5Z7j9JbGPhxxiN88aKL/rz/wx8F5FCOu 7JvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788854488; x=1789459288; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xDQnWL+09MRQg3JHhpcIAGJ0gQMTwutt9tXBZmD4GyU=; b=WPyKK6dcT/a9G67EtL23bKWnS1P7O+OWv2fDjgfUVMrlI6XmuY3OCV2Cc+lmrWzRnL rnpSV2SS0sFyHiYrpXTCzcyRBWJoZPS36eo3UG4TqVv5WI9wZ7zuAtu3Rw1KbAgWaV0h oNxrqq9h+QuvBDV5gBgB3WFDTYXVf40aR6JXBwJG+YsZgOC4RYrTLct0FXSrUYvZ2kN/ hUStBVskmmrddqer5VSMUDjNpcp3zGf2fsf81COQ0EzSHIXOI+7khm7ZiqePP6YzgCAy sGFlkCzhzOY3ks31rTfb02p9+1lpR/1fTbmdqC/VhFPCeu/XW8Nk7Sn0EhXDo5HIk9ru DXSA== X-Forwarded-Encrypted: i=1; AKwUvBzlYVJR89nYs+/XFbNGpa9CIS7IufegShvMzgNMrjwdUr3nMVCr7UCUD31FqOKn4rFNsobJLK9e4oQz@vger.kernel.org X-Gm-Message-State: AFuF++l0HSrMd6PSoG8nn0yJc0In1Oq/aRkBe9yWzkYYR6agyig8gt+h QeOktZXjY7jvWo5CzrvQXZCP7vbdgi+3L9zhhKhxe+9XYHy9CBK54ZSJ X-Gm-Gg: AYBFou3msMY+VnDRnXjRLJm6RGr470gS7/OBJwcnb1MxbRIwQ5DpxGq6a09cJbVPtb0 HDgumKFW8/Cq3FZia5Z6P1jXs9DsTLjeUaeY+V1iVtSJ2VmL4nDuhOo7bY699PoI2IC566zHfgS XJAmDv40XHbRE1g+abk8XAkb/pfQpfTMmuzgTc5vQCho+/d3mp+m8RrEHublsuzGK8ZTu6DZk+W 4kOmjLg3jnrk3yxuiqaDGKBaYSehBcM4e17tPRGEcRQ87zRkDOJbISnpV2woIdBih+VfxfLOZ5M HvPtOVhq6tXyjqZZUbocR16y4a1VEkABVQQ9+zHI9fPHm4MYBeI3YIKWGSS6Jd1hVGL1/AnXH5k Ub3/KhhGZ6hy8XXTAKrKzM2ZYbJZ1g8HJaApkPaxlCjL7ZK1jNZproYiQWNqb3k/xK0HoaCwhe0 OARoozcnd7PPiEvmY4QGgS3saAl15cTdQiZPyz7o6lDzWMlPQQFvHJNg00xjzzC+nrsMZBtRS/T VI+T9trKCMZ3KciY8mNctraWYha3QZTBYrkvn1Z5G8ecbebtwrlktvNP5TnoxfeLbEf6q3dhXR0 5lMH4/kHfOmpowR/H7iKVdLw0IYQ8jwV+Y37Q2dTNpNmvUZiwOeCVy51QpC/xoOqSqC8Y8QZfEr CW3/UOa6TyMzLPrPvha4UV7r6F+TrBldWqCUATrqMZphAEI5QFHVLvj6Kr9PtNZDe7E/rNb7k2D xEqtb4 X-Received: by 2002:a05:600c:3b07:b0:49c:fa20:cbfb with SMTP id 5b1f17b1804b1-49cfa20cd04mr250384235e9.18.1788854487057; Tue, 08 Sep 2026 01:01:27 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49cf75ce49esm641964095e9.1.2026.09.08.01.01.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2026 01:01:26 -0700 (PDT) Date: Tue, 8 Sep 2026 10:01:23 +0200 From: Joshua Crofts To: Chang Yu Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Shi Hao , "Jose A. Perez de Azpillaga" Subject: Re: [PATCH v2 2/2] iio: light: add AS7343 multi-spectral sensor driver Message-ID: <20260908100123.00005af7@gmail.com> In-Reply-To: <20260907210042.32552-3-marcus.yu.56@gmail.com> References: <20260907210042.32552-1-marcus.yu.56@gmail.com> <20260907210042.32552-3-marcus.yu.56@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi Chang, Please check out Sashiko's review, there are some PM runtime things that should be resolved + some comments inline. https://sashiko.dev/#/patchset/20260907210042.32552-1-marcus.yu.56%40gmail.com Thanks! Josh On Mon, 7 Sep 2026 14:00:42 -0700 Chang Yu wrote: ... > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include + bits.h, types.h, (asm headers go separately, as IIO headers). > + > +#include > + ... > +struct as7343_data { > + struct regmap *regmap; > +}; > + > +static int as7343_read_raw(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, int *val, > + int *val2, long mask) > +{ > + struct as7343_data *data = iio_priv(indio_dev); > + int ret; > + unsigned int unused; > + u16 result; > + > + switch (mask) { > + case IIO_CHAN_INFO_RAW: { The device should resume here, otherwise you'll be reading while suspended. > + /* > + * Reading ASTATUS latches all data registers to this read. > + * We don't care about the returned saturation/gain status for > + * now. > + */ Sashiko points out that a mutex here would come in handy. If you're going to add a mutex, use the guard(mutex) macro for automatic unlocking on scope exit. > + ret = regmap_read(data->regmap, AS7343_ASTATUS, &unused); > + if (ret) > + return ret; > + > + ret = regmap_bulk_read(data->regmap, chan->address, &result, 2); > + if (ret) > + return ret; > + > + *val = le16_to_cpu(result); > + return IIO_VAL_INT; > + } > + > + default: > + return -EINVAL; > + } > +} > + > +static const char *as7343_channel_label(struct iio_chan_spec const *chan) > +{ > + switch (chan->channel) { > + case AS7343_CHAN_IDX_FZ: > + return "FZ"; > + case AS7343_CHAN_IDX_FY: > + return "FY"; > + case AS7343_CHAN_IDX_FXL: > + return "FXL"; > + case AS7343_CHAN_IDX_NIR: > + return "NIR"; > + case AS7343_CHAN_IDX_F2: > + return "F2"; > + case AS7343_CHAN_IDX_F3: > + return "F3"; > + case AS7343_CHAN_IDX_F4: > + return "F4"; > + case AS7343_CHAN_IDX_F6: > + return "F6"; > + case AS7343_CHAN_IDX_F1: > + return "F1"; > + case AS7343_CHAN_IDX_F7: > + return "F7"; > + case AS7343_CHAN_IDX_F8: > + return "F8"; > + case AS7343_CHAN_IDX_F5: > + return "F5"; > + default: > + return NULL; > + } > +} > + > +static int as7343_read_label(struct iio_dev *indio_dev, > + struct iio_chan_spec const *chan, char *label) > +{ > + const char *name; > + > + name = as7343_channel_label(chan); > + if (!name) > + return -EINVAL; A blank line here would be better. > + return sysfs_emit(label, "%s\n", name); > +} > + > +static const struct iio_info as7343_info = { > + .read_raw = as7343_read_raw, > + .read_label = as7343_read_label, > +}; > + > +static const struct regmap_config as7343_regmap_config = { > + .name = "as7343", > + .reg_bits = 8, > + .val_bits = 8, > + .max_register = AS7343_MAX, > + .reg_format_endian = REGMAP_ENDIAN_LITTLE, > + .val_format_endian = REGMAP_ENDIAN_LITTLE, > + .cache_type = REGCACHE_NONE, > +}; > + > +static int as7343_setup_device(struct device *dev, struct as7343_data *data) > +{ > + unsigned int val; > + u16 step; __le16 instead of u16. > + int ret; > + > + /* Power on */ > + ret = regmap_set_bits(data->regmap, AS7343_ENABLE, AS7343_ENABLE_PON); > + if (ret) > + return ret; > + > + /* Need to set REG_BANK to 1 before we can access ID */ > + ret = regmap_set_bits(data->regmap, AS7343_CFG0, AS7343_CFG0_REG_BANK); > + if (ret) > + return ret; > + > + ret = regmap_read(data->regmap, AS7343_ID, &val); You should check the value of ret as well in case of a regmap failure. -- Kind regards, Joshua Crofts