Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: pankaj.gupta@oss.nxp.com
Cc: conor+dt@kernel.org, Frank.Li@kernel.org, imx@lists.linux.dev,
	robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v49 6/7] arm64: dts: imx8ulp: add secure enclave node
Date: Tue, 08 Sep 2026 12:00:09 +0000	[thread overview]
Message-ID: <20260908120010.15E3B1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260908-imx-se-if-v49-6-a59529118839@nxp.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately states that it adds a label for 'sram@2201f000', but the patch actually adds the label to 'sram@22010000'.
--

commit dbbf090119a95f58809b81bd6ae60d95c81f233f
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

arm64: dts: imx8ulp: add secure enclave node

This commit adds the EdgeLock Enclave (ELE) secure-enclave node to the 
i.MX8ULP SoC dtsi. It also adds an SRAM label for the node to reference 
and keeps the enclave disabled by default.

> Add the EdgeLock Enclave (ELE) secure-enclave node to the i.MX8ULP SoC
> dtsi, together with a label for sram@2201f000 that the node references.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index 777b89ed68490..ac8293f81c6b2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
[ ... ]
> @@ -154,7 +154,7 @@ sosc: clock-sosc {
>  		#clock-cells = <0>;
>  	};
>  
> -	sram@22010000 {
> +	sram0: sram@22010000 {
>  		compatible = "mmio-sram";
>  		reg = <0x0 0x22010000 0x0 0x10000>;

[Severity: Medium]
The commit message states that it adds a label for sram@2201f000, but the
patch actually applies the label sram0 to sram@22010000.

Could the commit message be updated to reflect the actual memory region 
being labeled, or should the label be applied to a different address?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-imx-se-if-v49-0-a59529118839@nxp.com?part=6

  reply	other threads:[~2026-09-08 12:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 17:18 [PATCH v49 0/7] firmware: imx: driver for NXP secure-enclave pankaj.gupta
2026-09-08 17:18 ` [PATCH v49 1/7] Documentation/firmware: add imx/se to other_interfaces pankaj.gupta
2026-09-08 17:18 ` [PATCH v49 2/7] dt-bindings: arm: fsl: add imx-se-fw binding doc pankaj.gupta
2026-09-08 17:18 ` [PATCH v49 3/7] firmware: imx: add driver for NXP EdgeLock Enclave pankaj.gupta
2026-09-08 12:03   ` sashiko-bot
2026-09-08 17:18 ` [PATCH v49 4/7] firmware: imx: device context dedicated to priv pankaj.gupta
2026-09-08 17:18 ` [PATCH v49 5/7] firmware: imx: adds miscdev pankaj.gupta
2026-09-08 12:05   ` sashiko-bot
2026-09-08 17:18 ` [PATCH v49 6/7] arm64: dts: imx8ulp: add secure enclave node pankaj.gupta
2026-09-08 12:00   ` sashiko-bot [this message]
2026-09-08 17:18 ` [PATCH v49 7/7] arm64: dts: imx8ulp: add reserved memory for EdgeLock Enclave pankaj.gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260908120010.15E3B1F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=pankaj.gupta@oss.nxp.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox