Re: [PATCH 1/2] dt-bindings: i2c: Add NXP PCA9641 I2C bus master arbiter

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The PCA9641 acts as an interrupt controller for downstream devices by propagating interrupts, but the binding omits the required `interrupt-controller` and `#interrupt-cells` properties.
--

commit f66b0c3d86e4ae950a20caea6a9eb2ad2243149c
Author: Shiv Prakash Gupta <shivprakash.gupta@nxp.com>
Subject: dt-bindings: i2c: Add NXP PCA9641 I2C bus master arbiter

This commit adds a device tree binding schema for the NXP PCA9641 2-to-1 I2C
bus master arbiter. The PCA9641 arbitrates between two upstream I2C masters
using a lock/grant model and supports an optional interrupts property for
interrupt-assisted arbitration.

diff --git a/Documentation/devicetree/bindings/i2c/nxp,pca9641.yaml b/Documentation/devicetree/bindings/i2c/nxp,pca9641.yaml
new file mode 100644
index 0000000000000..649a3f6d1776f
--- /dev/null
+++ b/Documentation/devicetree/bindings/i2c/nxp,pca9641.yaml
[ ... ]
> properties:
>   compatible:
>     const: nxp,pca9641

[Severity: Medium]
Since the commit message notes the PCA9641 has an INT_IN interrupt input that
propagates downstream slave interrupts upstream, it appears to act as an
interrupt controller. 

Should the interrupt-controller and #interrupt-cells properties be defined here
to expose the hardware's capabilities to schema validation?

[ ... ]
> required:
>   - compatible
>   - reg
>   - i2c-arb
> 
> additionalProperties: false

[Severity: Medium]
If a downstream I2C device correctly specifies interrupt-parent = <&i2c_arbiter>
to route its interrupts through the PCA9641, would the device tree fail schema
validation because additionalProperties: false is set and the interrupt
controller properties are omitted?

Should the interrupt-controller and #interrupt-cells properties be included in
this required block to ensure nodes are correctly validated?

> 
> examples:
>   - |
>     /* Minimal example: polling mode (no interrupt wiring) */

[Severity: Medium]
If the interrupt controller properties are added to the required block, would
these examples also need to be updated to include them so the examples can
continue to pass dt_binding_check?

>     i2c {
>         #address-cells = <1>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908123146.1839854-1-shivprakash.gupta@nxp.com?part=1