From: sashiko-bot@kernel.org
To: "Oleg Keri" <okerixx@gmail.com>
Cc: mfd@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH 2/2] mfd: qcom-pm8008: support PMICs with no interrupt line
Date: Tue, 08 Sep 2026 13:15:21 +0000 [thread overview]
Message-ID: <20260908131522.475D41F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260908130745.2545-3-okerixx@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description is not capitalized, violating MFD subsystem guidelines.
--
commit 18efba6bffe886fb1172493d0880293e52f677a5
Author: Oleg Keri <okerixx@gmail.com>
mfd: qcom-pm8008: support PMICs with no interrupt line
This commit updates the qcom-pm8008 driver to allow probing PMICs without an
interrupt line. It skips IRQ chip registration if the interrupt is absent and
registers only the regulator cell, since the temperature alarm and GPIO cells
require an IRQ domain.
> mfd: qcom-pm8008: support PMICs with no interrupt line
[Severity: Low]
This isn't a bug, but does this commit message subject line follow the MFD
subsystem formatting guidelines? The documentation requires capitalizing the
description after the subsystem prefix, so "support" should likely be changed
to "Support".
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260908130745.2545-1-okerixx@gmail.com?part=2
next prev parent reply other threads:[~2026-09-08 13:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 13:07 [PATCH 0/2] mfd: qcom-pm8008: support PMICs with no interrupt line Oleg Keri
2026-09-08 13:07 ` [PATCH 1/2] dt-bindings: mfd: qcom,pm8008: make the interrupt line optional Oleg Keri
2026-09-08 13:22 ` sashiko-bot
2026-09-08 13:07 ` [PATCH 2/2] mfd: qcom-pm8008: support PMICs with no interrupt line Oleg Keri
2026-09-08 13:15 ` sashiko-bot [this message]
2026-09-08 13:40 ` [PATCH 0/2] " Oleg Keri
2026-09-10 9:10 ` Jishnu Prakash
2026-09-10 9:19 ` Konrad Dybcio
2026-09-10 12:44 ` Oleg Keri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908131522.475D41F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=okerixx@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox