Re: [PATCH v4 1/5] dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added GPIO provider capabilities 'gpio-controller' and '#gpio-cells' are missing from the schema's 'required' list.
--

commit 6d6cb30a1eb86b847e98eea66d5ba6cc77a091a7
Author: Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>

dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller

The TC9563 PCIe switch embeds a GPIO controller providing 37 GPIO
lines. Describe the switch node itself as the embedded GPIO controller
and document the per-port reset-gpios property.

> diff --git a/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml b/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> index f084830c6d0cb..2f03e4e45114d 100644
> --- a/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> +++ b/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
> @@ -31,6 +31,11 @@ properties:
>      description:
>        GPIO controlling the RESX# pin.
>  
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +

[Severity: Medium]
Should these newly added GPIO provider capabilities be included in the
schema's required properties list?

Looking at the required list in
Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml:

required:
  - resx-gpios
  - vdd18-supply
  - vdd09-supply
  - vddc-supply
  - vddio1-supply
  - vddio2-supply
  - vddio18-supply
  - i2c-parent

If the new capabilities are omitted from this list, device tree nodes missing
gpio-controller and #gpio-cells will silently pass schema validation,
allowing incomplete configurations to enter the device tree.

At runtime, dependent nodes (such as the downstream ports attempting to use
reset-gpios) could fail when the provider is misconfigured.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-pci-tc9563-aux-v4-0-c7fc7778292b@oss.qualcomm.com?part=1