Re: [PATCH v5 6/8] dt-bindings: reset: Add mmsys reset ids for mt8167

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The mt8167-mmsys reset provider capability is introduced without updating the YAML binding to require #reset-cells.
--

commit 58d3f60477024bb27299c071d1ec1f38c92deeac
Author: Luca Leonardo Scorcia <l.scorcia@gmail.com>
Subject: dt-bindings: reset: Add mmsys reset ids for mt8167

According to the SoC data sheet, the mt8167 has 28 mmsys resets. This commit
adds the corresponding IDs that can be used in device trees to identify
subsystem resets.

> diff --git a/include/dt-bindings/reset/mediatek,mt8167-mmsys.h b/include/dt-bindings/reset/mediatek,mt8167-mmsys.h
> new file mode 100644
> index 0000000000000..b21f67b3b55c7
> --- /dev/null
> +++ b/include/dt-bindings/reset/mediatek,mt8167-mmsys.h
> @@ -0,0 +1,35 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
> +#ifndef _DT_BINDINGS_RESET_MEDIATEK_MT8167_MMSYS_H_
> +#define _DT_BINDINGS_RESET_MEDIATEK_MT8167_MMSYS_H_
> +
> +/* MMSYS reset IDs */
> +#define MT8167_MMSYS_SW0_RST_B_SMI_COMMON	0

[Severity: Medium]
This commit introduces a new reset provider capability by adding reset IDs
for mt8167-mmsys, but should the corresponding YAML binding be updated as
well?

Looking at Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml,
when hardware gains new provider capabilities like resets, the standard
properties such as #reset-cells must be added to the required list or a
compatible string-specific conditional block.

Without this update, a device tree node using mediatek,mt8167-mmsys could
omit the #reset-cells property and still pass dtbs_check schema validation.

This allows incomplete device trees to slip through, potentially causing
runtime failures for reset consumers.

Should the mediatek,mmsys.yaml binding be updated to enforce #reset-cells
for this compatible string?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908174259.9009-1-l.scorcia@gmail.com?part=6