Re: [PATCH net-next v2 3/9] dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing array length constraints (`minItems` / `maxItems`) on `clock-names` in conditional blocks allows mismatched `clocks` and `clock-names` lengths to pass schema validation.
--

commit 53e47f10606b15f76c5e6798405fb948136930d0
Author: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>

dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible
    
Shikra's EMAC requires two additional clocks for NOC interconnect
access. This commit adds qcom,shikra-ethqos to the compatible enum
and an if/else block for clock constraints.

> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 423959cb928d9..ad2cc706fa740 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
[ ... ]
> @@ -92,6 +99,41 @@ required:
>    - clock-names
>    - reg-names
>  
> +allOf:
> +  - $ref: snps,dwmac.yaml#
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,shikra-ethqos
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 6
> +        clock-names:
> +          items:
> +            - const: stmmaceth

[Severity: Low]
Is a minItems: 6 constraint missing for clock-names in this block?

Without it, this property inherits the top-level minItems: 4, which means
a device tree node with 6 clocks but only 4 clock-names could silently
pass dtbs_check schema validation.

> +            - const: pclk
> +            - const: ptp_ref
> +            - const: rgmii
> +            - const: axi-noc
> +            - const: pcie-tile-axi-noc
> +      required:
> +        - operating-points-v2
> +    else:
> +      properties:
> +        clocks:
> +          maxItems: 4
> +        clock-names:
> +          items:
> +            - const: stmmaceth

[Severity: Low]
Does this block also need a maxItems: 4 constraint for clock-names?

Without it, clock-names can match up to the top-level definition's 6
elements for the older compatibles, allowing mismatched clocks and
clock-names array lengths to silently pass schema validation.

> +            - const: pclk
> +            - const: ptp_ref
> +            - enum:
> +                - rgmii
> +                - phyaux

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-shikra_ethernet-v2-0-bbe3389d0652@oss.qualcomm.com?part=3