From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: robh@kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org,
Frank.Li@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout
Date: Tue, 08 Sep 2026 21:59:41 +0000 [thread overview]
Message-ID: <20260908215942.6539C1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260908215519.33061-1-marex@nabladev.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Devicetree unit address mismatch for `wifi-id` node
--
commit 082793f42f1059431835df44206b8d1014d852b6
Author: Marek Vasut <marex@nabladev.com>
arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout
This commit describes the ID EEPROM nWP GPIO, label, and nvmem layout for
the i.MX8MM and i.MX8MP eDM SBCs.
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> index 472c584fb3bd2..92df23e432499 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
[ ... ]
> + board-id@100 {
> + reg = <0x100 0x4>;
> + };
> +
> + wifi-id@1200 {
> + reg = <0x120 0x4>;
> + };
[Severity: Low]
Does this unit address mismatch the reg property? The node name uses 1200,
but the base address in the reg property is 120. This will likely cause a
dtc compiler warning for a simple-bus unit address format error.
> + };
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
> index cb28cf1cdd23f..dbdf4b8f696f6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
[ ... ]
> + board-id@100 {
> + reg = <0x100 0x4>;
> + };
> +
> + wifi-id@1200 {
> + reg = <0x120 0x4>;
> + };
[Severity: Low]
Is the unit address 1200 a typo here as well? The reg property specifies 120
for the i.MX8MP SBC rev.900, which does not match the node name.
[ ... ]
> + board-id@100 {
> + reg = <0x100 0x4>;
> + };
> +
> + wifi-id@1200 {
> + reg = <0x120 0x4>;
> + };
[Severity: Low]
Similarly for the i.MX8MP SBC rev.902, should this unit address be updated
to match the 120 specified in the reg property?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260908215519.33061-1-marex@nabladev.com?part=1
prev parent reply other threads:[~2026-09-08 21:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 21:54 [PATCH] arm64: dts: imx8mm: imx8mp: Update EEPROM with nWP GPIO, label and layout Marek Vasut
2026-09-08 21:59 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908215942.6539C1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=marex@nabladev.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox