From: Neo Chang <YLCHANG2@nuvoton.com>
To: <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <perex@perex.cz>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <linux-sound@vger.kernel.org>,
<devicetree@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<neo.chang70@gmail.com>, <kchsu0@nuvoton.com>,
<sjlin0@nuvoton.com>, "Neo Chang" <YLCHANG2@nuvoton.com>
Subject: [PATCH v4 1/2] ASoC: codecs: nau8360: Block DSP path selection when firmware load fails
Date: Wed, 9 Sep 2026 10:59:46 +0800 [thread overview]
Message-ID: <20260909025947.287120-2-YLCHANG2@nuvoton.com> (raw)
In-Reply-To: <20260909025947.287120-1-YLCHANG2@nuvoton.com>
Block the DSP path selection if the firmware fails to load to prevent
invalid routing states.
If the firmware is not ready, nau8360_dac_mux_put_enum() will print
a rate-limited warning and return -EBUSY. This rejects the invalid
userspace request and maintains the original hardware state without
causing audio wrong status.
Signed-off-by: Neo Chang <YLCHANG2@nuvoton.com>
---
sound/soc/codecs/nau8360.c | 7 ++++++-
sound/soc/codecs/nau8360.h | 6 ++++++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/nau8360.c b/sound/soc/codecs/nau8360.c
index 89b8ee80d6c8..277aa982c341 100644
--- a/sound/soc/codecs/nau8360.c
+++ b/sound/soc/codecs/nau8360.c
@@ -715,10 +715,15 @@ static int nau8360_dac_mux_put_enum(struct snd_kcontrol *kcontrol,
int ret = 0;
if (snd_soc_dapm_get_bias_level(dapm) > SND_SOC_BIAS_STANDBY) {
- dev_warn(nau8360->dev, "changing path is not allowed during playback");
+ dev_warn_ratelimited(nau8360->dev, "changing path is not allowed during playback");
return ret;
}
+ if (item[0] == NAU8360_DAC_SRC_DSP && !nau8360->load_fw_done) {
+ dev_warn_ratelimited(nau8360->dev, "Cannot enable DSP: Firmware not ready or disabled\n");
+ return -EBUSY;
+ }
+
mutex_lock(&nau8360->lock);
ret = snd_soc_dapm_put_enum_double(kcontrol, ucontrol);
diff --git a/sound/soc/codecs/nau8360.h b/sound/soc/codecs/nau8360.h
index cc640ba8c838..71396747c0fa 100644
--- a/sound/soc/codecs/nau8360.h
+++ b/sound/soc/codecs/nau8360.h
@@ -870,6 +870,12 @@ enum {
NAU8360_TDM_TXN,
};
+/* DAC Source Path*/
+enum {
+ NAU8360_DAC_SRC_HW1 = 0,
+ NAU8360_DAC_SRC_DSP,
+};
+
/* PLL Source */
enum {
NAU8360_PLL_MCLK,
--
2.25.1
next prev parent reply other threads:[~2026-09-09 2:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 2:59 [PATCH v4 0/2] ASoC: codecs: nau8360: Fix DSP routing and deadlock issues Neo Chang
2026-09-09 2:59 ` Neo Chang [this message]
2026-09-09 3:13 ` [PATCH v4 1/2] ASoC: codecs: nau8360: Block DSP path selection when firmware load fails sashiko-bot
2026-09-09 2:59 ` [PATCH v4 2/2] ASoC: codecs: nau8360: Fix AB-BA deadlock in mux update Neo Chang
2026-09-09 3:30 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909025947.287120-2-YLCHANG2@nuvoton.com \
--to=ylchang2@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kchsu0@nuvoton.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=neo.chang70@gmail.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sjlin0@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox