Re: [PATCH PRELIMINARY 3/5] arm64: dts: qcom: shikra-cqm-evk: enable the first Ethernet port

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The `rgmii_phy_supply` regulator will never be enabled because its consumer property `vdda-2p5-supply` is unrecognized, leaving the Ethernet PHY unpowered.
--

commit 02736a4e2fd0c007683a5dc746272d6c69e9e024
Author: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>

arm64: dts: qcom: shikra-cqm-evk: enable the first Ethernet port

Enable ethernet0 for the Shikra CQM EVK board with its DP83867 RGMII
PHY. The PHY is powered on using a GPIO-controlled 2.5V regulator.

> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> index b112b21b1d79b..d093b80034823 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts

[ ... ]

> +		rgmii_phy: ethernet-phy@7 {
> +			compatible = "ethernet-phy-id2000.a231";
> +			reg = <0x7>;
> +			reset-gpios = <&tlmm 135 GPIO_ACTIVE_LOW>;
> +			reset-assert-us = <10000>;
> +			reset-deassert-us = <50000>;
> +			vdda-2p5-supply = <&rgmii_phy_supply>;

[Severity: High]
Will this regulator ever be enabled?

Because vdda-2p5-supply isn't a recognized property by the DP83867 PHY
driver or the core MDIO/PHY frameworks, it appears this regulator is never
requested or enabled by any consumer.

Since rgmii_phy_supply defaults to output-low via its pinctrl and isn't
marked with regulator-always-on, does this mean the Ethernet PHY remains
unpowered and non-functional?

> +		};
> +	};
>  };

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-shikra_ethernet_dts-v1-0-69c0c5c7c124@oss.qualcomm.com?part=3