Re: [PATCH v6 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The conditional block applying Agilex5-specific constraints in the dt-binding was not updated to include the new `altr,socfpga-stmmac-agilex5-tsn` compatible string, leading to incorrect validation constraints.
--

commit b74ca4590795b8666403b95078f84d25977f7624
Author: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>

dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible
    
The Agilex5 SoCDK TSN Config2 gmac1 path includes an FPGA soft-IP
GMII-to-RGMII converter between the DWXGMAC and the PHY. The converter
provides the RGMII TX/RX delays and presents GMII toward the MAC, unlike
a plain altr,socfpga-stmmac-agilex5 port with no such converter.

> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index db93436c96fa6..9150504e922be 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
[ ... ]
> @@ -44,7 +45,9 @@ properties:
>            - const: snps,dwmac-3.74a
>            - const: snps,dwmac
>        - items:
> -          - const: altr,socfpga-stmmac-agilex5
> +          - enum:
> +              - altr,socfpga-stmmac-agilex5
> +              - altr,socfpga-stmmac-agilex5-tsn
>            - const: snps,dwxgmac-2.10
>  
>    clocks:

[Severity: Medium]
Will this new compatible string cause incomplete schema validation for device
trees because it is missing from the conditional block?

Looking at the allOf conditional block later in the file:

  - if:
      properties:
        compatible:
          contains:
            const: altr,socfpga-stmmac-agilex5
    then:
      properties:
        interrupts:
          minItems: 17

Should this block be updated to use an enum that matches both
altr,socfpga-stmmac-agilex5 and altr,socfpga-stmmac-agilex5-tsn so the correct
hardware constraints are applied?

Without this update, device trees for the TSN variant might fail validation
when they correctly have 17 interrupts, or pass validation when they
incorrectly have fewer.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908070557.3585-1-muhammad.nazim.amirul.nazle.asmade@altera.com?part=3