From: sashiko-bot@kernel.org
To: "Yaozhong Li" <yaozhonguwl@gmail.com>
Cc: devicetree@vger.kernel.org, lee@kernel.org, robh@kernel.org,
mfd@lists.linux.dev, conor+dt@kernel.org
Subject: Re: [RFC PATCH 3/3] arm64: dts: rockchip: fix power-off on Firefly-RK3399
Date: Wed, 09 Sep 2026 09:35:36 +0000 [thread overview]
Message-ID: <20260909093536.7CC381F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260909092728.1859-4-yaozhonguwl@gmail.com>
> poweroff on this board drops the rails and immediately brings them back
> up, so it reboots instead of staying off and U-Boot reports a power-on
> reset.
>
> Firefly's BSP drives GPIO1_D0 and GPIO1_B5 low during shutdown, before
> writing the RK808's shutdown bit. Mainline does not describe GPIO1_D0 at
> all, and describes GPIO1_B5 as the backlight enable GPIO - the vendor's
> own backlight node has no enable GPIO. Nothing therefore releases either
> line at power-off, and while the backlight owns GPIO1_B5 it can hold it
> asserted, which is enough to make the board come back up on its own.
>
> Describe both lines in the PMIC node and drop the backlight enable-gpios,
> with the settle time the vendor uses.
>
> Fixes: 171582e00db1 ("arm64: dts: rockchip: add support for firefly-rk3399 board")
> Signed-off-by: Yaozhong Li <yaozhonguwl@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909092728.1859-1-yaozhonguwl@gmail.com?part=3
prev parent reply other threads:[~2026-09-09 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 9:27 [RFC PATCH 0/3] Fix poweroff restarting the board on Firefly-RK3399 Yaozhong Li
2026-09-09 9:27 ` [RFC PATCH 1/3] dt-bindings: mfd: rk808: add board level power hold GPIOs Yaozhong Li
2026-09-09 9:32 ` sashiko-bot
2026-09-09 9:27 ` [RFC PATCH 2/3] mfd: rk8xx: release the power hold GPIOs before powering off Yaozhong Li
2026-09-09 9:35 ` sashiko-bot
2026-09-09 13:08 ` Lee Jones
2026-09-09 9:27 ` [RFC PATCH 3/3] arm64: dts: rockchip: fix power-off on Firefly-RK3399 Yaozhong Li
2026-09-09 9:35 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909093536.7CC381F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yaozhonguwl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox