Re: [PATCH net-next v10 1/4] dt-bindings: net: dsa: microchip: Add KSZ8995XA

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added compatible string 'microchip,ksz8995xa' (a 5-port switch) is incorrectly added to an exclusion list meant for 3-port switches, bypassing generic DSA port validation.
--

commit 2397d2b8fd3c47150c21e2d07ecb537ee6972ff6
Author: Linus Walleij <linusw@kernel.org>

dt-bindings: net: dsa: microchip: Add KSZ8995XA

This commit adds a new compatible string for the KSZ8995XA 5-port switch. It
updates the main properties list and an if-then conditional block in the
device tree binding schema.

> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> index 8d4a3a9a33fcc..ed39530b6cbbb 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
[ ... ]
> @@ -122,6 +123,7 @@ allOf:
>              enum:
>                - microchip,ksz8863
>                - microchip,ksz8873
> +              - microchip,ksz8995xa

[Severity: Low]
Does adding this 5-port switch to this specific enum block bypass generic
DSA port validation?

Since this list routes these specific compatible strings to the 'else' branch
which enforces a 3-port maximum limit, adding the KSZ8995XA here appears to
apply 3-port validation rules to a 5-port switch.

This could lead to incomplete schema evaluation for ports 3 and 4, either
allowing invalid configurations to silently pass or causing valid
configurations to fail validation when running dt_binding_check.

>      then:
>        $ref: dsa.yaml#/$defs/ethernet-ports
>      else:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-ks8995-to-ksz8-v10-0-7379239eb65f@kernel.org?part=1