Re: [PATCH v17 12/22] dt-bindings: media: i2c: add MAX9296A, MAX96716A, MAX96792A

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `i2c-alias-pool` property is overly restricted to a maximum of 2 items, which breaks valid multi-device configurations.
- [Medium] The `i2c-atr` child node fails to mandate `#address-cells` and `#size-cells`.
--

commit 6d3d3d8d9d81c31ffd5ad3feef43850ff819e86e
Author: Cosmin Tanislav <demonsingur@gmail.com>

dt-bindings: media: i2c: add MAX9296A, MAX96716A, MAX96792A

The MAX9296A deserializer converts single or dual serial inputs to MIPI
CSI-2 outputs. The GMSL2 links operate at a fixed rate of 3Gbps or 6Gbps
in the forward direction and 187.5Mbps in the reverse direction.

> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml
> new file mode 100644
> index 0000000000000..de6bfcec5dc63
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max9296a.yaml

[ ... ]

> +  port0-poc-supply:
> +    description: Regulator providing Power over Coax for GMSL port 0
> +
> +  port1-poc-supply:
> +    description: Regulator providing Power over Coax for GMSL port 1
> +
> +  i2c-alias-pool:
> +    maxItems: 2

[Severity: High]
Does this limit to a maximum of 2 items break valid multi-device configurations?

The i2c-alias-pool provides a pool of I2C aliases for the I2C Address
Translator (ATR). Every remote I2C peripheral accessed through the
deserializer (serializers, image sensors, EEPROMs) requires one alias
from this pool.

A dual-link deserializer configuration with a serializer and a sensor
on each link requires at least 4 aliases. By restricting maxItems to
2, the schema appears to artificially prevent users from specifying
enough aliases for a standard fully-populated setup.

> +
> +  i2c-atr:
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +      '#address-cells':
> +        const: 1
> +
> +      '#size-cells':
> +        const: 0
> +
> +    patternProperties:

[Severity: Medium]
Should the i2c-atr node mandate #address-cells and #size-cells in a required
array?

The i2c-atr node defines patternProperties for child nodes i2c@[0-1],
which contain a reg property. Any parent node containing children
with unit addresses must specify #address-cells and #size-cells.

While the schema defines these properties here, it does not seem to
include a required array for them within the i2c-atr node definition,
allowing a structurally invalid device tree to silently pass validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909-gmsl2-3_serdes-v17-0-002499e534e8@analog.com?part=12