From: sashiko-bot@kernel.org
To: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2] riscv: dts: spacemit: k3: add i2s0-i2s5 nodes
Date: Wed, 09 Sep 2026 17:26:39 +0000 [thread overview]
Message-ID: <20260909172639.BCDE91F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260910-kx-i2s-dts-v2-1-91f5376c899d@linux.spacemit.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added I2S device tree nodes use hardcoded magic numbers for DMA channels instead of the available hardware macros from `k3-pdma.h`.
--
commit 8163a94c4a6b08c0fea00752b0853d3f434a12d1
Author: Troy Mitchell <troy.mitchell@linux.spacemit.com>
riscv: dts: spacemit: k3: add i2s0-i2s5 nodes
Add the six SSPA-based I2S controller nodes for the K3 SoC.
i2s0 and i2s2-i2s5 each have a dedicated per-controller sysclk
divider, so they use the published 7-clock layout.
Link: https://lore.kernel.org/all/20260721-kx-i2s-dts-v1-0-d22cb6cfaab5@linux.spacemit.com/
> diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
> index c3f2dce0969c0..f2ff9f02249c3 100644
> --- a/arch/riscv/boot/dts/spacemit/k3.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
[ ... ]
> @@ -1140,6 +1140,85 @@ uart10: serial@d401f000 {
> status = "disabled";
> };
>
> + i2s0: i2s@d4026000 {
> + compatible = "spacemit,k3-i2s";
> + reg = <0x0 0xd4026000 0x0 0x30>;
> + clocks = <&syscon_mpmu CLK_MPMU_I2S0_SYSCLK>,
> + <&syscon_apbc CLK_APBC_I2S0_BCLK>,
> + <&syscon_apbc CLK_APBC_I2S0_BUS>,
> + <&syscon_apbc CLK_APBC_I2S0>,
> + <&syscon_mpmu CLK_MPMU_I2S0_SYSCLK_DIV>,
> + <&syscon_mpmu CLK_MPMU_I2S_SYSCLK>,
> + <&syscon_mpmu CLK_MPMU_I2S_BCLK>;
> + clock-names = "sysclk", "bclk", "bus", "func",
> + "sysclk_div", "c_sysclk", "c_bclk";
> + dmas = <&pdma 21>, <&pdma 22>;
[Severity: Low]
Could this use the available hardware macros from k3-pdma.h instead of
hardcoded magic numbers, such as <&pdma K3_PDMA_SSPA0_TX>,
<&pdma K3_PDMA_SSPA0_RX>?
> + dma-names = "tx", "rx";
> + resets = <&syscon_apbc RESET_APBC_I2S0>;
> + #sound-dai-cells = <0>;
> +
> + status = "disabled";
> + };
> +
> + i2s1: i2s@d4026800 {
> + compatible = "spacemit,k3-i2s";
> + reg = <0x0 0xd4026800 0x0 0x30>;
> + clocks = <&syscon_mpmu CLK_MPMU_I2S1_SYSCLK>,
> + <&syscon_apbc CLK_APBC_I2S1_BCLK>,
> + <&syscon_apbc CLK_APBC_I2S1_BUS>,
> + <&syscon_apbc CLK_APBC_I2S1>,
> + <&syscon_mpmu CLK_MPMU_I2S_SYSCLK>,
> + <&syscon_mpmu CLK_MPMU_I2S_BCLK>;
> + clock-names = "sysclk", "bclk", "bus", "func",
> + "c_sysclk", "c_bclk";
> + dmas = <&pdma 23>, <&pdma 24>;
[Severity: Low]
Could this use the available hardware macros from k3-pdma.h instead of
hardcoded magic numbers, such as <&pdma K3_PDMA_SSPA1_TX>,
<&pdma K3_PDMA_SSPA1_RX>?
> + dma-names = "tx", "rx";
> + resets = <&syscon_apbc RESET_APBC_I2S1>;
> + #sound-dai-cells = <0>;
> +
> + status = "disabled";
> + };
> +
> + i2s2: i2s@d4027000 {
> + compatible = "spacemit,k3-i2s";
> + reg = <0x0 0xd4027000 0x0 0x30>;
> + clocks = <&syscon_mpmu CLK_MPMU_I2S2_SYSCLK>,
> + <&syscon_apbc CLK_APBC_I2S2_BCLK>,
> + <&syscon_apbc CLK_APBC_I2S2_BUS>,
> + <&syscon_apbc CLK_APBC_I2S2>,
> + <&syscon_mpmu CLK_MPMU_I2S2_SYSCLK_DIV>,
> + <&syscon_mpmu CLK_MPMU_I2S_SYSCLK>,
> + <&syscon_mpmu CLK_MPMU_I2S_BCLK>;
> + clock-names = "sysclk", "bclk", "bus", "func",
> + "sysclk_div", "c_sysclk", "c_bclk";
> + dmas = <&pdma 56>, <&pdma 57>;
[Severity: Low]
Could this use the available hardware macros from k3-pdma.h instead of
hardcoded magic numbers, such as <&pdma K3_PDMA_SSPA2_TX>,
<&pdma K3_PDMA_SSPA2_RX>?
> + dma-names = "tx", "rx";
> + resets = <&syscon_apbc RESET_APBC_I2S2>;
> + #sound-dai-cells = <0>;
> +
> + status = "disabled";
> + };
> +
> + i2s3: i2s@d4027800 {
> + compatible = "spacemit,k3-i2s";
> + reg = <0x0 0xd4027800 0x0 0x30>;
> + clocks = <&syscon_mpmu CLK_MPMU_I2S3_SYSCLK>,
> + <&syscon_apbc CLK_APBC_I2S3_BCLK>,
> + <&syscon_apbc CLK_APBC_I2S3_BUS>,
> + <&syscon_apbc CLK_APBC_I2S3>,
> + <&syscon_mpmu CLK_MPMU_I2S3_SYSCLK_DIV>,
> + <&syscon_mpmu CLK_MPMU_I2S_SYSCLK>,
> + <&syscon_mpmu CLK_MPMU_I2S_BCLK>;
> + clock-names = "sysclk", "bclk", "bus", "func",
> + "sysclk_div", "c_sysclk", "c_bclk";
> + dmas = <&pdma 58>, <&pdma 59>;
[Severity: Low]
Could this use the available hardware macros from k3-pdma.h instead of
hardcoded magic numbers, such as <&pdma K3_PDMA_SSPA3_TX>,
<&pdma K3_PDMA_SSPA3_RX>?
[ ... ]
> @@ -1170,6 +1249,46 @@ spi1: spi@d4040800 {
> status = "disabled";
> };
>
> + i2s4: i2s@d4041000 {
> + compatible = "spacemit,k3-i2s";
> + reg = <0x0 0xd4041000 0x0 0x30>;
> + clocks = <&syscon_mpmu CLK_MPMU_I2S4_SYSCLK>,
> + <&syscon_apbc CLK_APBC_I2S4_BCLK>,
> + <&syscon_apbc CLK_APBC_I2S4_BUS>,
> + <&syscon_apbc CLK_APBC_I2S4>,
> + <&syscon_mpmu CLK_MPMU_I2S4_SYSCLK_DIV>,
> + <&syscon_mpmu CLK_MPMU_I2S_SYSCLK>,
> + <&syscon_mpmu CLK_MPMU_I2S_BCLK>;
> + clock-names = "sysclk", "bclk", "bus", "func",
> + "sysclk_div", "c_sysclk", "c_bclk";
> + dmas = <&pdma 60>, <&pdma 61>;
[Severity: Low]
Could this use the available hardware macros from k3-pdma.h instead of
hardcoded magic numbers, such as <&pdma K3_PDMA_SSPA4_TX>,
<&pdma K3_PDMA_SSPA4_RX>?
> + dma-names = "tx", "rx";
> + resets = <&syscon_apbc RESET_APBC_I2S4>;
> + #sound-dai-cells = <0>;
> +
> + status = "disabled";
> + };
> +
> + i2s5: i2s@d4041800 {
> + compatible = "spacemit,k3-i2s";
> + reg = <0x0 0xd4041800 0x0 0x30>;
> + clocks = <&syscon_mpmu CLK_MPMU_I2S5_SYSCLK>,
> + <&syscon_apbc CLK_APBC_I2S5_BCLK>,
> + <&syscon_apbc CLK_APBC_I2S5_BUS>,
> + <&syscon_apbc CLK_APBC_I2S5>,
> + <&syscon_mpmu CLK_MPMU_I2S5_SYSCLK_DIV>,
> + <&syscon_mpmu CLK_MPMU_I2S_SYSCLK>,
> + <&syscon_mpmu CLK_MPMU_I2S_BCLK>;
> + clock-names = "sysclk", "bclk", "bus", "func",
> + "sysclk_div", "c_sysclk", "c_bclk";
> + dmas = <&pdma 62>, <&pdma 63>;
[Severity: Low]
Could this use the available hardware macros from k3-pdma.h instead of
hardcoded magic numbers, such as <&pdma K3_PDMA_SSPA5_TX>,
<&pdma K3_PDMA_SSPA5_RX>?
> + dma-names = "tx", "rx";
> + resets = <&syscon_apbc RESET_APBC_I2S5>;
> + #sound-dai-cells = <0>;
> +
> + status = "disabled";
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-kx-i2s-dts-v2-1-91f5376c899d@linux.spacemit.com?part=1
next prev parent reply other threads:[~2026-09-09 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 17:17 [PATCH v2] riscv: dts: spacemit: k3: add i2s0-i2s5 nodes Troy Mitchell
2026-09-09 17:26 ` sashiko-bot [this message]
2026-09-10 1:32 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909172639.BCDE91F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox