From: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
To: Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>,
Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Subject: [PATCH v2 2/5] ASoC: qcom: sc8280xp: Extend hw_params for QAIF backends
Date: Thu, 10 Sep 2026 20:32:39 +0530 [thread overview]
Message-ID: <20260910-shikra-machine-v2-v2-2-9bf6bad589d8@oss.qualcomm.com> (raw)
In-Reply-To: <20260910-shikra-machine-v2-v2-0-9bf6bad589d8@oss.qualcomm.com>
Prepare the sc8280xp machine driver for Shikra EVK variants that use
Audio-IF (QAIF) based backends:
- Add a `cpu_dai_fmt` field in qcom_snd_soc_common so that boards can
override the default SND_SOC_DAIFMT_BP_FP for MI2S and TDM paths.
- Handle the QAIF MI2S (AIF_MI2S_RX_0 ... AIF_MI2S_TX_12) and QAIF TDM
(AIF_TDM_RX_0 ... AIF_TDM_TX_12) DAI ID ranges in
sc8280xp_snd_hw_params() so that format and clock setup applies to
QAIF backends.
- Add VA_CODEC_DMA_TX_1 to qcom_snd_is_sdw_dai() and
sc8280xp_be_hw_params_fixup() so that the VA codec DMA path is
recognised as a SoundWire DAI.
- Widen the sc8280xp_add_be_ops() link filter to also cover links
with codecs (num_codecs > 0), since QAIF FE+BE links are not
marked with no_pcm = 1.
No functional change for existing platforms.
Co-developed-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>
Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
---
sound/soc/qcom/sc8280xp.c | 30 +++++++++++++++++++++++-------
sound/soc/qcom/sdw.c | 1 +
2 files changed, 24 insertions(+), 7 deletions(-)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
index 4d48e1012cd4..452296a9e67d 100644
--- a/sound/soc/qcom/sc8280xp.c
+++ b/sound/soc/qcom/sc8280xp.c
@@ -67,6 +67,7 @@ struct qcom_snd_soc_common {
const struct snd_kcontrol_new *controls;
int num_controls;
unsigned int codec_dai_fmt;
+ unsigned int cpu_dai_fmt;
bool codec_sysclk_set;
bool mi2s_mclk_enable;
bool mi2s_bclk_enable;
@@ -126,9 +127,15 @@ static int sc8280xp_tdm_hw_params(struct snd_pcm_substream *substream,
if (!cpu_cfg.slots)
return 0;
- ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_BP_FP);
- if (ret && ret != -ENOTSUPP)
- return ret;
+ if (data->priv->cpu_dai_fmt) {
+ ret = snd_soc_dai_set_fmt(cpu_dai, data->priv->cpu_dai_fmt);
+ if (ret && ret != -ENOTSUPP)
+ return ret;
+ } else {
+ ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_BP_FP);
+ if (ret && ret != -ENOTSUPP)
+ return ret;
+ }
if (data->priv->codec_dai_fmt) {
for_each_rtd_codec_dais(rtd, i, codec_dai) {
@@ -234,6 +241,7 @@ static int sc8280xp_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
case TX_CODEC_DMA_TX_1:
case TX_CODEC_DMA_TX_2:
case TX_CODEC_DMA_TX_3:
+ case VA_CODEC_DMA_TX_1:
channels->min = 1;
break;
default:
@@ -260,9 +268,16 @@ static int sc8280xp_snd_hw_params(struct snd_pcm_substream *substream,
case QUINARY_MI2S_RX ... QUINARY_MI2S_TX:
case SENARY_MI2S_RX ... SENARY_MI2S_TX:
case LPI_MI2S_RX_0 ... LPI_MI2S_TX_4:
- ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_BP_FP);
- if (ret && ret != -ENOTSUPP)
- return ret;
+ case AIF_MI2S_RX_0 ... AIF_MI2S_TX_12:
+ if (data->priv->cpu_dai_fmt) {
+ ret = snd_soc_dai_set_fmt(cpu_dai, data->priv->cpu_dai_fmt);
+ if (ret && ret != -ENOTSUPP)
+ return ret;
+ } else {
+ ret = snd_soc_dai_set_fmt(cpu_dai, SND_SOC_DAIFMT_BP_FP);
+ if (ret && ret != -ENOTSUPP)
+ return ret;
+ }
if (data->priv->codec_dai_fmt) {
ret = snd_soc_dai_set_fmt(codec_dai,
@@ -296,6 +311,7 @@ static int sc8280xp_snd_hw_params(struct snd_pcm_substream *substream,
}
break;
case PRIMARY_TDM_RX_0 ... QUINARY_TDM_TX_7:
+ case AIF_TDM_RX_0 ... AIF_TDM_TX_12:
return sc8280xp_tdm_hw_params(substream, params);
default:
break;
@@ -382,7 +398,7 @@ static void sc8280xp_add_be_ops(struct snd_soc_card *card)
int i;
for_each_card_prelinks(card, i, link) {
- if (link->no_pcm == 1) {
+ if (link->no_pcm == 1 || link->num_codecs > 0) {
link->init = sc8280xp_snd_init;
link->be_hw_params_fixup = sc8280xp_be_hw_params_fixup;
link->ops = &sc8280xp_be_ops;
diff --git a/sound/soc/qcom/sdw.c b/sound/soc/qcom/sdw.c
index 6576b47a4c8c..e19adb7c750b 100644
--- a/sound/soc/qcom/sdw.c
+++ b/sound/soc/qcom/sdw.c
@@ -30,6 +30,7 @@ static bool qcom_snd_is_sdw_dai(int id)
case TX_CODEC_DMA_TX_5:
case RX_CODEC_DMA_RX_6:
case RX_CODEC_DMA_RX_7:
+ case VA_CODEC_DMA_TX_1:
case SLIMBUS_0_RX...SLIMBUS_6_TX:
return true;
default:
--
2.34.1
next prev parent reply other threads:[~2026-09-10 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 15:02 [PATCH v2 0/5] ASoC: qcom: Shikra machine driver and DT binding support Ajay Kumar Nandam
2026-09-10 15:02 ` [PATCH v2 1/5] ASoC: dt-bindings: qcom,sm8250: add Shikra sound card compatibles Ajay Kumar Nandam
2026-09-10 15:02 ` Ajay Kumar Nandam [this message]
2026-09-10 15:19 ` [PATCH v2 2/5] ASoC: qcom: sc8280xp: Extend hw_params for QAIF backends sashiko-bot
2026-09-10 15:02 ` [PATCH v2 3/5] ASoC: qcom: sc8280xp: Add shikra-cqm-evk compatible support Ajay Kumar Nandam
2026-09-10 15:02 ` [PATCH v2 4/5] ASoC: qcom: sc8280xp: Add shikra-cqs-evk " Ajay Kumar Nandam
2026-09-10 15:02 ` [PATCH v2 5/5] ASoC: qcom: sc8280xp: Add shikra-iqs-evk " Ajay Kumar Nandam
2026-09-10 15:13 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910-shikra-machine-v2-v2-2-9bf6bad589d8@oss.qualcomm.com \
--to=ajay.nandam@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mohammad.rafi.shaik@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox