Re: [PATCH 1/2] regulator: dt-bindings: Add MPS MPQ4210

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `mps,fb-voltage-divider` property schema omits `minItems: 2` or an explicit `items` list, allowing incomplete arrays to pass validation.
--

commit 9d4fa47cff6967eb8bf59f67ec44cae66abc946a
Author: Tapio Reijonen <tapio.reijonen@vaisala.com>

regulator: dt-bindings: Add MPS MPQ4210

This commit introduces a new device tree binding for the MPQ4210
buck-boost controller. It specifies standard regulator properties and
adds the mps,fb-voltage-divider property to scale reference voltages.

> diff --git a/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml b/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml
> new file mode 100644
> index 0000000000000..e9e7a87e7533d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml

[ ... ]

> +  mps,fb-voltage-divider:
> +    description: An array of two integers containing the resistor values R1
> +      and R2 of the output feedback voltage divider in ohms.
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    maxItems: 2

[Severity: Low]
Does this schema allow incomplete arrays to pass validation?

The property description mentions an array of two integers for R1 and R2,
but without minItems: 2 or an explicit items list, a device tree node with
only one element could silently pass dt_binding_check.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-mpq4210-regulator-v1-0-d37e208dfc8d@vaisala.com?part=1