From: sashiko-bot@kernel.org
To: "Jerome Brunet" <jbrunet@baylibre.com>
Cc: robh@kernel.org, mfd@lists.linux.dev, devicetree@vger.kernel.org,
conor+dt@kernel.org, linux-sunxi@lists.linux.dev, lee@kernel.org
Subject: Re: [PATCH v8 2/5] mfd: axp20x-i2c: Fix i2c instantiation
Date: Thu, 10 Sep 2026 10:52:23 +0000 [thread overview]
Message-ID: <20260910105223.950F81F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260910-axp318-regulator-v8-2-e906a61a7f3d@baylibre.com>
> Apparently this device never really supported i2c instantiation via
> sysfs, because the driver does not even look at the i2c device data,
> which are not set. It would only probe if the device matched through DT.
>
> Fix that for correctness, even-though it is probably useless.
> Add the missing AXP323 while at it.
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/r/20260717090209.2A09B1F000E9@smtp.kernel.org
> Fixes: 41751b033aaa ("mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading")
> Acked-by: Chen-Yu Tsai <wens@kernel.org>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-axp318-regulator-v8-0-e906a61a7f3d@baylibre.com?part=2
next prev parent reply other threads:[~2026-09-10 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 10:44 [PATCH v8 0/5] regulator: Add X-Powers AXP318W PMIC support Jerome Brunet
2026-09-10 10:44 ` [PATCH v8 1/5] mfd: axp20x: Constify axp313 and axp717 cells Jerome Brunet
2026-09-10 10:49 ` sashiko-bot
2026-09-10 10:44 ` [PATCH v8 2/5] mfd: axp20x-i2c: Fix i2c instantiation Jerome Brunet
2026-09-10 10:52 ` sashiko-bot [this message]
2026-09-10 10:44 ` [PATCH v8 3/5] dt-bindings: mfd: x-powers,axp152: Document AXP318W Jerome Brunet
2026-09-10 10:53 ` sashiko-bot
2026-09-10 10:44 ` [PATCH v8 4/5] mfd: axp20x: Add support for AXP318W PMIC Jerome Brunet
2026-09-10 10:52 ` sashiko-bot
2026-09-10 10:44 ` [PATCH v8 5/5] regulator: axp20x: add support for the AXP318W Jerome Brunet
2026-09-10 10:51 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910105223.950F81F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=lee@kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox